From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 1OwSLtv+5mHaDAAAgWs5BA (envelope-from ) for ; Tue, 18 Jan 2022 18:54:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aMxqKdv+5mHKXwAAauVa8A (envelope-from ) for ; Tue, 18 Jan 2022 18:54:35 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F7BBBBE7 for ; Tue, 18 Jan 2022 18:54:35 +0100 (CET) Received: from localhost ([::1]:46624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9sgj-0004KF-99 for larch@yhetil.org; Tue, 18 Jan 2022 12:54:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9sgE-000498-LM for guix-patches@gnu.org; Tue, 18 Jan 2022 12:54:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9sgE-0002em-7U for guix-patches@gnu.org; Tue, 18 Jan 2022 12:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9sgE-0008VB-7f for guix-patches@gnu.org; Tue, 18 Jan 2022 12:54:02 -0500 Subject: bug#53213: [PATCH] daemon: Always default to gzip for log compression. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 18 Jan 2022 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53213 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 53213-done@debbugs.gnu.org Mail-Followup-To: 53213@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 53213-done@debbugs.gnu.org id=D53213.164252839432611 (code D ref 53213); Tue, 18 Jan 2022 17:54:02 +0000 Received: (at 53213-done) by debbugs.gnu.org; 18 Jan 2022 17:53:14 +0000 Received: from localhost ([127.0.0.1]:51597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9sfR-0008Tv-Uf for submit@debbugs.gnu.org; Tue, 18 Jan 2022 12:53:14 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:57394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9sfQ-0008Ti-8z for 53213-done@debbugs.gnu.org; Tue, 18 Jan 2022 12:53:12 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id BD0AE838; Tue, 18 Jan 2022 18:53:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oSWfyLYFci9W; Tue, 18 Jan 2022 18:53:06 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id A2100780; Tue, 18 Jan 2022 18:53:05 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220112172118.12250-1-ludo@gnu.org> <87ilunxcsc.fsf@gmail.com> Date: Tue, 18 Jan 2022 18:53:05 +0100 In-Reply-To: <87ilunxcsc.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 13 Jan 2022 21:37:55 -0500") Message-ID: <87y23dc4n2.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: BD0AE838 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642528475; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=XZHwIx6eoWp189J51NLKYEHh/qhR9o2lBn0f8fdey+0=; b=fbamTtM6Ng9LnFu1EhXLDrwigGWxdDlBkaC55PysfrekxKEIL+Qrx2WJbX/OZ11GdNxLfi aD98Q7nkRj+RCyeW3exTC/6pIE+qbSVU2NGx5ay05JOL97afzsyMV8vnCTjsczzZAugkVM ZtLmz0/42ciYXNQsLr7Hhj79XrDktHqSVuXc4RJZ0t1WnuMbDdLvp3NXVxXFmOVwnd2vs+ vZNoesVLc0rHyJO1WW+FgUMDr0JgLkAIUwatWfn/gQuk1xCLGiUKiHhMd45s7+rFtMGDhp 2BLvGrCgh5tcfxjUaDenEf8QaYKVD6mt5HboNZVQAnr2DqWBW4bxLP+J61spig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642528475; a=rsa-sha256; cv=none; b=tMGAvfvqB+7fvB0ZrCvSww4x9F0r3zNi2xqnKehmh5Pt5mnb0W+uq5PAjwQGYEu6uLF8Or TPRyBEgemNdRl7gxKzJ+L7e5ZupjfyBHgFVBfH0HrqOs6QBMbrBNzo4UMTM+V7HNiVgRcr hVE7rCg+8dwbztB5VrsAlLFP21KD8g3sqoElv+LdA8pLDj2rdnJ5cXGEarhVZFEYlVSfpH Mhj4mbpM2NOAgLuVwmCssZYUU5L43FdExVEP+ahfLxJXPGn7+70TyyujlNQfzhDOjdlFn5 rp9sT2lNd91eGYjZDarS15INPlTkSgqE4CFjbpBiFdH0kFY5Qs0i9T5YP+K/FQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.62 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3F7BBBBE7 X-Spam-Score: -3.62 X-Migadu-Scanner: scn1.migadu.com X-TUID: L1uxq4UCuKZ5 Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression' >> default to COMPRESSION_GZIP unconditionally. >> * gnu/services/base.scm ()[log-compression]: Default >> to 'gzip. >> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingl= y. >> --- >> doc/guix.texi | 4 ++-- >> gnu/services/base.scm | 2 +- >> nix/libstore/globals.cc | 4 ---- >> 3 files changed, 3 insertions(+), 7 deletions(-) >> >> Hello! >> >> I think bzip2 compression of the build logs doesn=E2=80=99t buy us much,= it >> doesn=E2=80=99t play well with =E2=80=98guix publish=E2=80=99, and bzip2= is generally rather >> uncommon these days=E2=80=94hence this patch. >> >> Thoughts? >> >> Ludo=E2=80=99. > > I haven't tried it, but the idea and code LGTM. Pushed in 575e52ac2b090fd194086e9c1c53bbf8055acbc2, thanks! Ludo=E2=80=99.