all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 63320-done@debbugs.gnu.org
Cc: Julien Lepiller <julien@lepiller.eu>,
	"pelzflorian \(Florian Pelz\)" <pelzflorian@pelzflorian.de>
Subject: bug#63320: [PATCH 0/2] Rewrite 'arguments' to gexps with 'guix style -S arguments'
Date: Thu, 18 May 2023 20:10:37 +0200	[thread overview]
Message-ID: <87y1ll1peq.fsf@gnu.org> (raw)
In-Reply-To: <cover.1683321561.git.ludo@gnu.org> ("Ludovic Courtès"'s message of "Fri, 5 May 2023 23:30:19 +0200")

Hi,

Ludovic Courtès <ludo@gnu.org> skribis:

> When preparing <https://guix.gnu.org/en/blog/2021/the-big-change/>, I didn’t
> consider converting ‘arguments’ from sexps to gexps a priority.  In practice,
> we’ve been doing that manually ever since but there’s a sort of a “contamination”
> aspect: due to inheritance, we often have to be careful enough to convert
> multiple packages at once or to not change anything, or we end up with gexp
> records inside sexps¹.  Automation appears to be overdue.
>
> The attached patches add ‘guix style -S arguments’, which rewrites ‘arguments’
> from sexps to gexps.  The change doesn’t involve any rebuild, so we could even
> run it en masse on the whole repo and be done with it.

Pushed as 2344ccee2f28f790fa0b69ecb1916c162c1f8c50, with Florian’s
news entry translation (I just realized I forgot to add you as
co-author, my apologies!).

I guess we should address the shortcomings I mentioned before we can run
it on the whole repo.

Thanks,
Ludo’.




      parent reply	other threads:[~2023-05-18 18:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 21:30 [bug#63320] [PATCH 0/2] Rewrite 'arguments' to gexps with 'guix style -S arguments' Ludovic Courtès
2023-05-05 21:40 ` [bug#63320] [PATCH 1/2] style: Add 'arguments' styling rule Ludovic Courtès
2023-05-05 21:40 ` [bug#63320] [PATCH 2/2] DRAFT news: Add entry to 'guix style -S arguments' Ludovic Courtès
2023-05-06 10:43   ` pelzflorian (Florian Pelz)
2023-05-18 18:10 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1ll1peq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=63320-done@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.