From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0NlGLUFqZmQugwAASxT56A (envelope-from ) for ; Thu, 18 May 2023 20:11:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6NRhLEFqZmSL2AAAG6o9tA (envelope-from ) for ; Thu, 18 May 2023 20:11:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D3A612F57 for ; Thu, 18 May 2023 20:11:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzi5g-0002AH-0h; Thu, 18 May 2023 14:11:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzi5e-00029j-MY for guix-patches@gnu.org; Thu, 18 May 2023 14:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzi5e-0007ir-7i for guix-patches@gnu.org; Thu, 18 May 2023 14:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzi5d-0002IO-RK for guix-patches@gnu.org; Thu, 18 May 2023 14:11:01 -0400 Subject: bug#63320: [PATCH 0/2] Rewrite 'arguments' to gexps with 'guix style -S arguments' Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 18 May 2023 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63320-done@debbugs.gnu.org Cc: Julien Lepiller , "pelzflorian \(Florian Pelz\)" Mail-Followup-To: 63320@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 63320-done@debbugs.gnu.org id=D63320.16844334548804 (code D ref 63320); Thu, 18 May 2023 18:11:01 +0000 Received: (at 63320-done) by debbugs.gnu.org; 18 May 2023 18:10:54 +0000 Received: from localhost ([127.0.0.1]:54482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzi5W-0002Hw-Ba for submit@debbugs.gnu.org; Thu, 18 May 2023 14:10:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzi5R-0002Hg-Ir for 63320-done@debbugs.gnu.org; Thu, 18 May 2023 14:10:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzi5J-0007e9-Bq; Thu, 18 May 2023 14:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=OvpVSs5vU4S/kKiosagu1JONqEPs1G2BlXMxsLOY6CY=; b=k0TPP4R1eS601+64x+ti O4BglSIqrcNolDTfMbD8k/3wF9dcm0m0kpc9dg8QJ3URVxOIjp5je5vpOKm4o6AWMSXOMEmnhFswW 3qjhfi2b5Qxhe4/OuEtFsfuCl2DrDQ3xyZo8Qupb2y0bUMB2W6VwVY1/l/zF20gbToYCCys4PPicM EjU/pGt19ZPZgcsJMfQDCEljMawz6CA1WSCASu/W8AzHAl5zpKrRKMkaRiP5noE1x38q7o0y0i0y5 hBlbXNLrwuCiRe3lpQm2kuPms40aILsxQH/vMv0LKx9tk2RBnhodvxT3Q1ssmLDd1gqB4U/4XLJtB qfSpfRl6pAg8EA==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzi5I-0008Q1-VV; Thu, 18 May 2023 14:10:41 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 18 May 2023 20:10:37 +0200 In-Reply-To: ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 5 May 2023 23:30:19 +0200") Message-ID: <87y1ll1peq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684433473; a=rsa-sha256; cv=none; b=FsmKDt/8Z3srCL4ZgylgA38LH6aPRUSjg71QBx1RmdGh1BhhYZAdxXyTbaKiSMk18WEiNu O70Jscnt4g3m+2/dajyKClXtrodlYiOLxvO/dswWZkRV6r1kXvl7kgU/Ra6UkHOYcEbYxS CCk9pNY7ctq2J9L9KIhf/AO/djdwpZchcGiPMgydAwl0Lcwb4h7N6pY5epoueDZhH2YOaf JEeEZhkLqqDNqMdD3ihJuI0HnEZ7EAuAZjx1LEpEV/lCeqGsh/eEZKzC1OMcGwGYawdTKZ p70bHQ6lc8qsnZYbE22L9rTMalB2qpm4ZBDGW/b4SFR6ZmZNEY2lhtfpk02sKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=k0TPP4R1; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684433473; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OvpVSs5vU4S/kKiosagu1JONqEPs1G2BlXMxsLOY6CY=; b=kqKvGZN12YAW8JP8avyTfvm5/NMsBChu8zab1cUiucIeh41iJp5D6XcFH6jL5mNBp22/3s jT5ZLkWoizeomG7WEgCZsTIup5Cjc10PUQHmsl0k3NYD0o2sRaquXh5mMikPuO2OcxWSRE q3EekhXe4kzpw4vJa5/Zvqmqpb6Ko+uUpvzIiceCAxFiWQFLVj6m2eyJdmWjzfGzxBWWcT p5WarQhdTpxs6ua6Fq8nebTCGbNezok3rHNkfvhNyJZJB3mvQYaYmSen6Mq72B/TiXN20Z h7cd/LQYqGi61lSrar710A4SWB2YdPC7/GQr7oi0fMF22Sun+kAfh0oOmMQeGA== X-Migadu-Spam-Score: -2.81 X-Spam-Score: -2.81 X-Migadu-Queue-Id: 7D3A612F57 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=k0TPP4R1; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: zh3Qyek2/Qb9 Hi, Ludovic Court=C3=A8s skribis: > When preparing , I did= n=E2=80=99t > consider converting =E2=80=98arguments=E2=80=99 from sexps to gexps a pri= ority. In practice, > we=E2=80=99ve been doing that manually ever since but there=E2=80=99s a s= ort of a =E2=80=9Ccontamination=E2=80=9D > aspect: due to inheritance, we often have to be careful enough to convert > multiple packages at once or to not change anything, or we end up with ge= xp > records inside sexps=C2=B9. Automation appears to be overdue. > > The attached patches add =E2=80=98guix style -S arguments=E2=80=99, which= rewrites =E2=80=98arguments=E2=80=99 > from sexps to gexps. The change doesn=E2=80=99t involve any rebuild, so = we could even > run it en masse on the whole repo and be done with it. Pushed as 2344ccee2f28f790fa0b69ecb1916c162c1f8c50, with Florian=E2=80=99s news entry translation (I just realized I forgot to add you as co-author, my apologies!). I guess we should address the shortcomings I mentioned before we can run it on the whole repo. Thanks, Ludo=E2=80=99.