From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: tcsh: Fix out of bounds read.
Date: Thu, 08 Dec 2016 10:39:21 +0100 [thread overview]
Message-ID: <87wpfan4ja.fsf@gnu.org> (raw)
In-Reply-To: <20161208004057.GA26321@jasmine> (Leo Famulari's message of "Wed, 7 Dec 2016 19:40:57 -0500")
Leo Famulari <leo@famulari.name> skribis:
> On Wed, Dec 07, 2016 at 01:55:47PM +0100, Marius Bakke wrote:
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>> > That could go to the next ‘staging’ branch or ‘core-updates’, which
>> > might be merged first. (How come this many packages depend on tcsh?)
>>
>> tcsh is used by the 'boost' and 'texlive' packages.
>
> Tcsh is a native-input of boost.
>
> I think that using a graft, as in the attached patch, should work.
>
> However, when applying this patch on top of a69bc7071ec (hydra: Fix
> wrong-num-args error when computing the cross jobs.) and building boost
> with this patch, the same derivation is built:
>
> $ ./pre-inst-env guix build boost && ./pre-inst-env guix build --no-grafts boost
> /gnu/store/nfg59rims86f87q5hasj8ngad3cd9dpa-boost-1.61.0
> /gnu/store/nfg59rims86f87q5hasj8ngad3cd9dpa-boost-1.61.0
>
> I'd expect it to change. Am I missing something?
Boost has no run-time dependency on tcsh, as shown by:
guix size boost | grep tcsh
This is probably the reason why tcsh is in ‘native-inputs’, and also the
reason why Boost is not grafted in this case.
It’s a case where using a graft allows us to not rebuild anything when
we know it wouldn’t make any difference.
Anyway, the patch LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2016-12-08 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 6:22 [PATCH 1/1] gnu: tcsh: Fix out of bounds read Leo Famulari
2016-12-07 8:09 ` Efraim Flashner
2016-12-07 10:54 ` Ludovic Courtès
2016-12-07 12:55 ` Marius Bakke
2016-12-08 0:40 ` Leo Famulari
2016-12-08 9:39 ` Ludovic Courtès [this message]
2016-12-08 18:54 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpfan4ja.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.