From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/1] gnu: tcsh: Fix out of bounds read. Date: Thu, 08 Dec 2016 10:39:21 +0100 Message-ID: <87wpfan4ja.fsf@gnu.org> References: <20161207080947.GA26434@macbook42.flashner.co.il> <87a8c89fgo.fsf@gnu.org> <87fulznbjg.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20161208004057.GA26321@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEvAl-0006ux-Pk for guix-devel@gnu.org; Thu, 08 Dec 2016 04:39:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEvAi-0006A4-La for guix-devel@gnu.org; Thu, 08 Dec 2016 04:39:27 -0500 In-Reply-To: <20161208004057.GA26321@jasmine> (Leo Famulari's message of "Wed, 7 Dec 2016 19:40:57 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > On Wed, Dec 07, 2016 at 01:55:47PM +0100, Marius Bakke wrote: >> Ludovic Court=C3=A8s writes: >>=20 >> > That could go to the next =E2=80=98staging=E2=80=99 branch or =E2=80= =98core-updates=E2=80=99, which >> > might be merged first. (How come this many packages depend on tcsh?) >>=20 >> tcsh is used by the 'boost' and 'texlive' packages. > > Tcsh is a native-input of boost. > > I think that using a graft, as in the attached patch, should work. > > However, when applying this patch on top of a69bc7071ec (hydra: Fix > wrong-num-args error when computing the cross jobs.) and building boost > with this patch, the same derivation is built: > > $ ./pre-inst-env guix build boost && ./pre-inst-env guix build --no-graft= s boost > /gnu/store/nfg59rims86f87q5hasj8ngad3cd9dpa-boost-1.61.0 > /gnu/store/nfg59rims86f87q5hasj8ngad3cd9dpa-boost-1.61.0 > > I'd expect it to change. Am I missing something? Boost has no run-time dependency on tcsh, as shown by: guix size boost | grep tcsh This is probably the reason why tcsh is in =E2=80=98native-inputs=E2=80=99,= and also the reason why Boost is not grafted in this case. It=E2=80=99s a case where using a graft allows us to not rebuild anything w= hen we know it wouldn=E2=80=99t make any difference. Anyway, the patch LGTM, thank you! Ludo=E2=80=99.