all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Chris Marusich <cmmarusich@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Why is "append" the activation service's "compose" procedure?
Date: Thu, 29 Mar 2018 13:25:19 +0200	[thread overview]
Message-ID: <87woxvw2cg.fsf@gnu.org> (raw)
In-Reply-To: <878tabs5fg.fsf@gmail.com> (Chris Marusich's message of "Thu, 29 Mar 2018 09:32:19 +0200")

Hello Chris,

Chris Marusich <cmmarusich@gmail.com> skribis:

> By the way, I noticed that the cups-service-type also uses "append" as
> its "compose" procedure.  I think this is suspicious.  The comment in
> the code says:
>
>     ;; Extensions consist of lists of packages (representing CUPS
>     ;; drivers, etc) that we just concatenate.
>     (compose append)

According to the comment, it should be ‘concatenate’ instead of
‘append’.

But like you write, it’s plausible that nobody tried to extend
‘cups-service-type’ so far, which is why we didn’t have any problems.

I think you can go ahead and make this change.

Thanks,
Ludo’.

      reply	other threads:[~2018-03-29 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23 10:17 Why is "append" the activation service's "compose" procedure? Chris Marusich
2018-03-26 13:02 ` Ludovic Courtès
2018-03-29  7:32   ` Chris Marusich
2018-03-29 11:25     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woxvw2cg.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=cmmarusich@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.