From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Why is "append" the activation service's "compose" procedure?
Date: Thu, 29 Mar 2018 13:25:19 +0200
Message-ID: <87woxvw2cg.fsf@gnu.org>
References: <87muyzdrjq.fsf@gmail.com> <87zi2vdm6r.fsf@gnu.org>
	<878tabs5fg.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1f1VgM-0004iF-3F
	for guix-devel@gnu.org; Thu, 29 Mar 2018 07:25:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1f1VgI-0000fB-44
	for guix-devel@gnu.org; Thu, 29 Mar 2018 07:25:26 -0400
Received: from hera.aquilenet.fr ([2a0c:e300::1]:49310)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1f1VgH-0000ex-Sx
	for guix-devel@gnu.org; Thu, 29 Mar 2018 07:25:22 -0400
In-Reply-To: <878tabs5fg.fsf@gmail.com> (Chris Marusich's message of "Thu, 29
	Mar 2018 09:32:19 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: guix-devel@gnu.org

Hello Chris,

Chris Marusich <cmmarusich@gmail.com> skribis:

> By the way, I noticed that the cups-service-type also uses "append" as
> its "compose" procedure.  I think this is suspicious.  The comment in
> the code says:
>
>     ;; Extensions consist of lists of packages (representing CUPS
>     ;; drivers, etc) that we just concatenate.
>     (compose append)

According to the comment, it should be =E2=80=98concatenate=E2=80=99 instea=
d of
=E2=80=98append=E2=80=99.

But like you write, it=E2=80=99s plausible that nobody tried to extend
=E2=80=98cups-service-type=E2=80=99 so far, which is why we didn=E2=80=99t =
have any problems.

I think you can go ahead and make this change.

Thanks,
Ludo=E2=80=99.