From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 39873@debbugs.gnu.org
Subject: [bug#39873] [PATCH 3/3] substitute: Close port at the end of http-multiple-get.
Date: Sat, 07 Mar 2020 22:14:03 +0100 [thread overview]
Message-ID: <87wo7veulg.fsf@gnu.org> (raw)
In-Reply-To: <20200302210735.13337-3-mail@cbaines.net> (Christopher Baines's message of "Mon, 2 Mar 2020 21:07:35 +0000")
Christopher Baines <mail@cbaines.net> scribes:
> * guix/scripts/substitute.scm (http-multiple-get): Add close-port call.
> ---
> guix/scripts/substitute.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
> index a88cb5bcfe..e3f5837a8e 100755
> --- a/guix/scripts/substitute.scm
> +++ b/guix/scripts/substitute.scm
> @@ -544,6 +544,7 @@ initial connection on which HTTP requests are sent."
> (()
> (match (drop requests processed)
> (()
> + (close-port p)
LGTM!
Did you notice a file descriptor leak somewhere?
Thank you!
Ludo’.
next prev parent reply other threads:[~2020-03-07 21:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 21:02 [bug#39873] [PATCH 0/3] http-multiple-get enhancements Christopher Baines
2020-03-02 21:07 ` [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches Christopher Baines
2020-03-02 21:07 ` [bug#39873] [PATCH 2/3] substitute: Make http-multiple-get batch size configurable Christopher Baines
2020-03-07 21:13 ` Ludovic Courtès
2020-03-02 21:07 ` [bug#39873] [PATCH 3/3] substitute: Close port at the end of http-multiple-get Christopher Baines
2020-03-07 21:14 ` Ludovic Courtès [this message]
2020-03-08 23:58 ` Christopher Baines
2020-03-07 21:12 ` [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches Ludovic Courtès
2020-03-09 0:07 ` Christopher Baines
2020-04-26 18:40 ` bug#39873: [PATCH 0/3] http-multiple-get enhancements Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo7veulg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39873@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.