From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:53138)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jAgml-0005Jv-HF
 for guix-patches@gnu.org; Sat, 07 Mar 2020 16:15:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jAgmk-0002oJ-O3
 for guix-patches@gnu.org; Sat, 07 Mar 2020 16:15:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:41681)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jAgmk-0002nE-Kk
 for guix-patches@gnu.org; Sat, 07 Mar 2020 16:15:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jAgmk-0001C5-BN
 for guix-patches@gnu.org; Sat, 07 Mar 2020 16:15:02 -0500
Subject: [bug#39873] [PATCH 3/3] substitute: Close port at the end of
 http-multiple-get.
Resent-Message-ID: <handler.39873.B39873.15836156514517@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87imjmeagu.fsf@cbaines.net>
 <20200302210735.13337-1-mail@cbaines.net>
 <20200302210735.13337-3-mail@cbaines.net>
Date: Sat, 07 Mar 2020 22:14:03 +0100
In-Reply-To: <20200302210735.13337-3-mail@cbaines.net> (Christopher Baines's
 message of "Mon, 2 Mar 2020 21:07:35 +0000")
Message-ID: <87wo7veulg.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 39873@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> scribes:

> * guix/scripts/substitute.scm (http-multiple-get): Add close-port call.
> ---
>  guix/scripts/substitute.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
> index a88cb5bcfe..e3f5837a8e 100755
> --- a/guix/scripts/substitute.scm
> +++ b/guix/scripts/substitute.scm
> @@ -544,6 +544,7 @@ initial connection on which HTTP requests are sent."
>            (()
>             (match (drop requests processed)
>               (()
> +              (close-port p)

LGTM!

Did you notice a file descriptor leak somewhere?

Thank you!

Ludo=E2=80=99.