From: Xinglu Chen <public@yoctocell.xyz>
To: 50796@debbugs.gnu.org
Cc: Antero Mejr <antero@mailbox.org>
Subject: [bug#50796] [PATCH 1/2] gnu: Add libphonenumber.
Date: Wed, 29 Sep 2021 13:42:15 +0200 [thread overview]
Message-ID: <87wnmz1uco.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210928205649.27328-2-antero@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 3512 bytes --]
On Tue, Sep 28 2021, Antero Mejr via Guix-patches via wrote:
> * gnu/packages/telephony.scm (libphonenumber): New variable.
> ---
> gnu/packages/telephony.scm | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index 48bbe12920..50b5790ae3 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -20,6 +20,7 @@
> ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
> ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
> +;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -54,12 +55,14 @@
> #:use-module (gnu packages documentation)
> #:use-module (gnu packages file)
> #:use-module (gnu packages protobuf)
> + #:use-module (gnu packages gawk)
> #:use-module (gnu packages gettext)
> #:use-module (gnu packages gl)
> #:use-module (gnu packages glib)
> #:use-module (gnu packages gnome)
> #:use-module (gnu packages gnupg)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages icu4c)
> #:use-module (gnu packages image)
> #:use-module (gnu packages libcanberra)
> #:use-module (gnu packages linphone)
> @@ -907,3 +910,38 @@ Initiation Protocol (SIP) and a multimedia framework.")
> telephony functionality into custom Telegram clients.")
> (home-page "https://github.com/zevlg/libtgvoip")
> (license license:unlicense)))
> +
> +(define-public libphonenumber
> + (package
> + (name "libphonenumber")
> + (version "8.12.33")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/google/libphonenumber")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-dir
> + (lambda _ (chdir "cpp")))
> + (replace 'check
> + (lambda _ (invoke "./libphonenumber_test"))))))
Great that you got the tests to run; however this ‘check’ phase doesn’t
respect the ‘--without-tests’ package transformation. The snippet below
should do.
--8<---------------cut here---------------start------------->8---
(lambda* (#:key tests? #:allow-other-keys)
(when tests?
(invoke "./libphonenumber_test")))
--8<---------------cut here---------------end--------------->8---
> + (inputs
> + `(("boost" ,boost)
> + ("googletest" ,googletest)
> + ("protobuf" ,protobuf)
> + ("icu4c" ,icu4c)))
> + (home-page "https://github.com/google/libphonenumber")
> + (synopsis "C++ library for phone number parsing")
> + (description
> + "@code{libphonenumber} is Google's common Java, C++ and JavaScript
> +library for parsing, formatting, and validating international phone numbers.")
> + (license license:asl2.0)))
For some reason the build is still not reproducible for me; I ran
diffoscope on the two outputs, and it produced 120 MB worth of output…
Maybe a third person could test if the build is reproducible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-29 11:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 3:28 [bug#50796] [PATCH] gnu: Add pn Antero Mejr via Guix-patches via
2021-09-28 18:59 ` [bug#50873] " Xinglu Chen
2021-09-28 20:56 ` [bug#50796] [PATCH 0/2] " Antero Mejr via Guix-patches via
2021-09-28 20:56 ` [bug#50796] [PATCH 1/2] gnu: Add libphonenumber Antero Mejr via Guix-patches via
2021-09-29 11:42 ` Xinglu Chen [this message]
2022-01-17 10:06 ` Nicolas Goaziou
2021-09-28 20:56 ` [bug#50796] [PATCH 2/2] gnu: Add pn Antero Mejr via Guix-patches via
2022-08-11 19:11 ` [bug#50796] [PATCH] " Antero Mejr via Guix-patches via
2022-08-12 14:39 ` bug#50796: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnmz1uco.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50796@debbugs.gnu.org \
--cc=antero@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.