From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gHO8NldRVGGGTgAAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 13:43:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +OFrMldRVGH4BAAAB5/wlQ (envelope-from ) for ; Wed, 29 Sep 2021 11:43:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7C63325298 for ; Wed, 29 Sep 2021 13:43:15 +0200 (CEST) Received: from localhost ([::1]:45252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVXzW-0001e1-Ik for larch@yhetil.org; Wed, 29 Sep 2021 07:43:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVXzK-0001c8-Ev for guix-patches@gnu.org; Wed, 29 Sep 2021 07:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36384) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVXzK-0004dF-6c for guix-patches@gnu.org; Wed, 29 Sep 2021 07:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVXzJ-0001Nk-Q6 for guix-patches@gnu.org; Wed, 29 Sep 2021 07:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50796] [PATCH 1/2] gnu: Add libphonenumber. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50796 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50796@debbugs.gnu.org Cc: Antero Mejr X-Debbugs-Original-To: Antero Mejr via Guix-patches via , 50796@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16329157535276 (code B ref -1); Wed, 29 Sep 2021 11:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Sep 2021 11:42:33 +0000 Received: from localhost ([127.0.0.1]:47930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVXyr-0001N2-17 for submit@debbugs.gnu.org; Wed, 29 Sep 2021 07:42:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:47860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVXyk-0001Me-UR for submit@debbugs.gnu.org; Wed, 29 Sep 2021 07:42:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVXyi-0000sw-Jj for guix-patches@gnu.org; Wed, 29 Sep 2021 07:42:26 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:47280 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVXyg-000465-On for guix-patches@gnu.org; Wed, 29 Sep 2021 07:42:24 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632915740; bh=EtseN51nB9zg8dnQHbY4+a7laxgnebkwo4cKxNIVsyM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=UGiR6DZo4GVUFEeyZZiE9b1tenFsxT/0PbZqyU9Qp4byxIIPeKhvt/BRJpukj7+Ne 9nXJMG8iWperYkwKpn6+MMIz+kWIr5GBdB1FB++LQUAZ3CRqoK4IXELXQNfvAHmMT2 W9JMXHgt7UE3Ay+xVVDWboN4N/bWy5bwtkApHKbI= In-Reply-To: <20210928205649.27328-2-antero@mailbox.org> References: <20210928205649.27328-1-antero@mailbox.org> <20210928205649.27328-2-antero@mailbox.org> Date: Wed, 29 Sep 2021 13:42:15 +0200 Message-ID: <87wnmz1uco.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, PDS_OTHER_BAD_TLD=1.999, PDS_RDNS_DYNAMIC_FP=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632915795; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=FRKM/ujUgm7w7XO512ZXQ3gsigyiDBBUYESMvI7h4dY=; b=jjbovZtGwSsJmLPGatYeJkxwLHBNLZ82qOKHOvDXUoC/dn+7gmzzuX8YMLzcEPrih5Mf18 6LKvoUsGApZzx7BKJtoXdU66Fpvq2BT7lbbm1haJh4CHkTtCr6NXP0PuYvVFbNLYDJpQBB QY4hITYhpFBneFbTk5Xf+W+okOnGplLTVt8SVKNptEqyANBTEtByBsayN9OLykAgidXfzv Ueq0SM4IRSLeN24om3J3G31OU8cZQtoOoobrP94hw5vrLydTA7aHQ4VDvln1DQWpNeRKm+ aImZrVvrUDuXf0vOW0x8ugTr3/mAF648KGMmrmiDQq7PbWT7WuJn+zocVTB5TQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632915795; a=rsa-sha256; cv=none; b=L2APWnbZSmu39a+qxtpN9lMY/Dl47c05CRO0aWGnH+isHNL1RaAiy0cfvl/4NpQyQmpAFx hOp0djZjTHJ5A8IeM2moZonQWbQVh2sGmLTP03cQj9X3s3m+oyCcJqhiHrigButYljpsaX SeF5raewPDe/vQZY18WWid0mlphtNRTwu4gFN2vy7Xrt+6E48RAYxhaBH2FTmGGq+J6Ccx RGzO4WtzgVtak0opZP4mJ/PnEI5VGeznikW2cFv2I1gLBw4Nmj26JV5WgSUaccoL1tsvrA mSP+1F+sgW2ICLdgItvosLmKNWiPJofkXwipAR9ZDe1AO/uH/UaSvoWvGELBcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=UGiR6DZo; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=UGiR6DZo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7C63325298 X-Spam-Score: -3.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: FpTEcTquMoz4 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Sep 28 2021, Antero Mejr via Guix-patches via wrote: > * gnu/packages/telephony.scm (libphonenumber): New variable. > --- > gnu/packages/telephony.scm | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm > index 48bbe12920..50b5790ae3 100644 > --- a/gnu/packages/telephony.scm > +++ b/gnu/packages/telephony.scm > @@ -20,6 +20,7 @@ > ;;; Copyright =C2=A9 2020, 2021 Maxim Cournoyer > ;;; Copyright =C2=A9 2020 Vincent Legoll > ;;; Copyright =C2=A9 2021 LibreMiami > +;;; Copyright =C2=A9 2021 Antero Mejr > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -54,12 +55,14 @@ > #:use-module (gnu packages documentation) > #:use-module (gnu packages file) > #:use-module (gnu packages protobuf) > + #:use-module (gnu packages gawk) > #:use-module (gnu packages gettext) > #:use-module (gnu packages gl) > #:use-module (gnu packages glib) > #:use-module (gnu packages gnome) > #:use-module (gnu packages gnupg) > #:use-module (gnu packages gtk) > + #:use-module (gnu packages icu4c) > #:use-module (gnu packages image) > #:use-module (gnu packages libcanberra) > #:use-module (gnu packages linphone) > @@ -907,3 +910,38 @@ Initiation Protocol (SIP) and a multimedia framework= .") > telephony functionality into custom Telegram clients.") > (home-page "https://github.com/zevlg/libtgvoip") > (license license:unlicense))) > + > +(define-public libphonenumber > + (package > + (name "libphonenumber") > + (version "8.12.33") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/google/libphonenumber") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25")))) > + (build-system cmake-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'enter-dir > + (lambda _ (chdir "cpp"))) > + (replace 'check > + (lambda _ (invoke "./libphonenumber_test")))))) Great that you got the tests to run; however this =E2=80=98check=E2=80=99 p= hase doesn=E2=80=99t respect the =E2=80=98--without-tests=E2=80=99 package transformation. The = snippet below should do. =2D-8<---------------cut here---------------start------------->8--- (lambda* (#:key tests? #:allow-other-keys) (when tests? (invoke "./libphonenumber_test"))) =2D-8<---------------cut here---------------end--------------->8--- > + (inputs > + `(("boost" ,boost) > + ("googletest" ,googletest) > + ("protobuf" ,protobuf) > + ("icu4c" ,icu4c))) > + (home-page "https://github.com/google/libphonenumber") > + (synopsis "C++ library for phone number parsing") > + (description > + "@code{libphonenumber} is Google's common Java, C++ and JavaScript > +library for parsing, formatting, and validating international phone numb= ers.") > + (license license:asl2.0))) For some reason the build is still not reproducible for me; I ran diffoscope on the two outputs, and it produced 120 MB worth of output=E2=80= =A6 Maybe a third person could test if the build is reproducible. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFUURcVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x54v0QAIyOlHGdy4ZlMXv282HZ89qE2eon mTSSgWqBV2KOlBrW4Y+PKpMWfRH9MvqFGM+PANohgXDbDJzHJWqu7QJB0e0izojn Bu7nDl+i0xH/SAu/A15/McV9fWGSbc3n2WFrG8xETYpY1aPpTjzAPcGlN6NlqHmX GWJ+VlCFx9n0f3IkbNtFvGLCi+i0upMGBLsQazzwB8duOdFrvpwgspilJaRH6Vt7 4uQW8MsvkAKhXAw0pZevcHMf1R87TM0Ttbthpqb+cze6yeAzp5dIbUqYoRyXVdZQ 5PrbJhrSbnL7cptDtstIeCupYF8pX5/RF00Rwn8XV/9uWgiHl1xpLrbdjvkRK/Yx k55hW8PiYYm2Mv9VfnKDi9ie+pLsbQnnnx8srWyV4av3kea6riTCrwD+z6a1DW/O pungg0hnQ0MVqtSSlIUgRXiTaHg0OfMXLySSBuQQchKw8rjZqQVqt+1kyX4y6aU8 f1ZcF/Bw6pSZsrLg5IxltpcmKEKhPUoHPhfOdx49TG0rg9QGzJeK/csyFjzWnwlK xLBbHybhww+SRUvDZwR62ZfN0CWn/V+LzsGu04676sJF48KWowP6/CTzV/RHlq1H ZAfdBQuyyPNwCdNoTdFvaSLitfkSKPOnXbI9jxe63u1OaZodtv92X3GUv58SS79B mRjmkcWz3ziR7w/S =kdgw -----END PGP SIGNATURE----- --=-=-=--