all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#53708] [PATCH] Fix Elixir substitution error
@ 2022-02-01 19:16 Cees de Groot
  2022-02-14 14:51 ` bug#53708: " Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Cees de Groot @ 2022-02-01 19:16 UTC (permalink / raw)
  To: 53708

From d9860a374c5b6e5b992439a232e6897bfde1e334 Mon Sep 17 00:00:00 2001
From: Cees de Groot <cg@evrl.com>
Date: Tue, 1 Feb 2022 14:12:17 -0500
Subject: [PATCH] Fix regex for ERTS_BIN substitution in Elixir

Something must have gone wrong during testing of the ELixir 1.13.2 patch I submitted last week. Apart from #53707, I also found out that the whole substitution regex did not work. This works better - it is still more brittle than I like, but apparently `substitute*`
does not work with fully anchored regexes.


---
 gnu/packages/elixir.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm
index fae8279e5c..55e17f2901 100644
--- a/gnu/packages/elixir.scm
+++ b/gnu/packages/elixir.scm
@@ -70,7 +70,7 @@ (define-public elixir
                 (("#!/bin/sh")
                  (string-append "#!" (search-input-file inputs "/bin/sh"))))
               (substitute* "bin/elixir"
-                (("^ERTS_BIN=$")
+                (("ERTS_BIN=\n")
                  (string-append
                   "ERTS_BIN="
                   ;; Elixir Releases will prepend to ERTS_BIN the path of
--
2.34.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#53708: [PATCH] Fix Elixir substitution error
  2022-02-01 19:16 [bug#53708] [PATCH] Fix Elixir substitution error Cees de Groot
@ 2022-02-14 14:51 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2022-02-14 14:51 UTC (permalink / raw)
  To: Cees de Groot; +Cc: 53708-done

Hi,

Cees de Groot <cg@evrl.com> skribis:

>>From d9860a374c5b6e5b992439a232e6897bfde1e334 Mon Sep 17 00:00:00 2001
> From: Cees de Groot <cg@evrl.com>
> Date: Tue, 1 Feb 2022 14:12:17 -0500
> Subject: [PATCH] Fix regex for ERTS_BIN substitution in Elixir
>
> Something must have gone wrong during testing of the ELixir 1.13.2 patch I submitted last week. Apart from #53707, I also found out that the whole substitution regex did not work. This works better - it is still more brittle than I like, but apparently `substitute*`
> does not work with fully anchored regexes.

I adjusted the commit log and applied it.

Thanks!

Ludo’.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-14 15:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 19:16 [bug#53708] [PATCH] Fix Elixir substitution error Cees de Groot
2022-02-14 14:51 ` bug#53708: " Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.