all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Justin Veilleux <terramorpha@cock.li>
Cc: 54918@debbugs.gnu.org
Subject: [bug#54918] [WIP] make guix-service-type more extendable
Date: Sat, 30 Apr 2022 16:18:23 +0200	[thread overview]
Message-ID: <87wnf64pu8.fsf@gnu.org> (raw)
In-Reply-To: <7c216565-f087-5d0a-bcea-66fe7c8a0295@cock.li> (Justin Veilleux's message of "Wed, 13 Apr 2022 14:54:05 -0400")

Hi Justin,

Justin Veilleux <terramorpha@cock.li> skribis:

> I realize that this change isn't trivial as it breaks some people's
> os.scm and requires updating the documentation, but I think it is a
> very low hanging fruit in terms of functionality.

I think the risk of breakage is low: the previous extension mechanism
had only one use case, qemu-binfmt.  That use case is now gone, so we
should be fine.

> +(define-record-type* <guix-extension>
> +  guix-extension make-guix-extension
> +  guix-extension?
> +  (authorized-keys guix-extension-authorized-keys ;list of gexps
> +                    (default '()))
> +  (substitute-urls guix-extension-substitute-urls ;list of strings
> +                    (default '()))
> +  (chroot-directories guix-extension-chroot-directories ;list of file-like/strings
> +                      (default '())))

I like this approach!

Together with update documentation and a changelog, it LGTM.  Could you
send an updated patch?

Thanks,
Ludo’.




  reply	other threads:[~2022-04-30 14:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 18:54 [bug#54918] [WIP] make guix-service-type more extendable Justin Veilleux
2022-04-30 14:18 ` Ludovic Courtès [this message]
2022-05-01 15:35   ` Justin Veilleux
2022-06-13 10:32     ` bug#54918: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnf64pu8.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=54918@debbugs.gnu.org \
    --cc=terramorpha@cock.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.