From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ELwvNlxFbWIHZwEAbAwnHQ (envelope-from ) for ; Sat, 30 Apr 2022 16:19:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GByBNlxFbWI3gQAA9RJhRA (envelope-from ) for ; Sat, 30 Apr 2022 16:19:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4153335DFA for ; Sat, 30 Apr 2022 16:19:08 +0200 (CEST) Received: from localhost ([::1]:42566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nknwB-0000kT-Fv for larch@yhetil.org; Sat, 30 Apr 2022 10:19:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nknw6-0000jx-97 for guix-patches@gnu.org; Sat, 30 Apr 2022 10:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nknw5-0004gG-Tq for guix-patches@gnu.org; Sat, 30 Apr 2022 10:19:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nknw5-0007XP-NN for guix-patches@gnu.org; Sat, 30 Apr 2022 10:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54918] [WIP] make guix-service-type more extendable Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 Apr 2022 14:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54918 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Justin Veilleux Cc: 54918@debbugs.gnu.org Received: via spool by 54918-submit@debbugs.gnu.org id=B54918.165132831128939 (code B ref 54918); Sat, 30 Apr 2022 14:19:01 +0000 Received: (at 54918) by debbugs.gnu.org; 30 Apr 2022 14:18:31 +0000 Received: from localhost ([127.0.0.1]:58782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nknvb-0007Wh-8V for submit@debbugs.gnu.org; Sat, 30 Apr 2022 10:18:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nknva-0007WU-8v for 54918@debbugs.gnu.org; Sat, 30 Apr 2022 10:18:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nknvU-0004do-V1; Sat, 30 Apr 2022 10:18:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=1XnVI1f2i6Lo2sw5Do2RDyYA8E2ohoiX5rAiEkR/4G8=; b=mM1g8WIdXm20FQMEKtf+ LSuY/qc/trkZY/K4v5zIhFEgPTmYcPC99gZN1hjjZnis5sC1SpI+3dVxo2ff8wXghSJ2ALzZ/pRq+ es72S7GBmPYxxCEGeXXU3xz+6ZjtjNSek74Q3Z8GzamJCMEZJl/D8YqMLI4iYUSCNjreckOF9B1nW 8qyj+R4KM7rPTKzSNh1xLtl3dC8bSIdVJvZSA1i8OjDhPmYGruVaiFk030+YYgNgRBszTcBSUjP6E P6B9CDH2L6aqk0Hqjpe5DFUZJiruKZP2EOSqmALdbOshLbjDQIfzOky9q/v9giOF6tfQHOryGS83i Xdj4AqiDI0tuvQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:49675 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nknvU-0005T3-Hb; Sat, 30 Apr 2022 10:18:24 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <7c216565-f087-5d0a-bcea-66fe7c8a0295@cock.li> Date: Sat, 30 Apr 2022 16:18:23 +0200 In-Reply-To: <7c216565-f087-5d0a-bcea-66fe7c8a0295@cock.li> (Justin Veilleux's message of "Wed, 13 Apr 2022 14:54:05 -0400") Message-ID: <87wnf64pu8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651328348; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1XnVI1f2i6Lo2sw5Do2RDyYA8E2ohoiX5rAiEkR/4G8=; b=VQAusVuiTaq9crqXq72TXB3AgGPRhnDdoSwoJp0TMQra/t/iylab8K/jIkPk5UHIbpBRMy jx5jdBOAJur0v1fzWhT92leXbmG//pDbiyD8LYevpYocvoXH17r71owcUVJ8G851Ip3cg+ qRs1FC+RGPhwHR4yFPDu/x7a1YbCfqYOnnLRhSr49XRCD6KvspM03EZl6mhslZfpczBhkc S6FWKbAnA4tQLGMCkLTd2fdQeImVFvaP9EEKGpeN8RSe4P6Re7njIfzqdx0e888nm+0zNr BKhOn9x47UPCPuI/wYy2uWQgHSS9H3KDFqGCfNxwnXVok62eqkTWlY7fb7GG9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651328348; a=rsa-sha256; cv=none; b=OkFAJPZvn0MeLxy828NWTKXkIAVZFD2l0ClbKiEe6TMLZia2lSsLwRBXwQyiIl1rN7YJr7 szBql5MbaUWWJbbQYmKBdjo1ZO1PKplgpN7zV7SinGXYDtUn6vJtq6bkjVWmpUTykXTQny VXkj0JOfOnUuyuZtjU3oM/tOWRgu8QiTYd4EKRlUr+q9XE6CoPzlleuY78VJVDtTVr4MUm U+T+Ig87DN0B69vfnvxSjN4bfwMegRLTi+B2055R8BhY/3y2srL0Kvih/cE/J0sWLgoVgN fxkHyBGnGOf8fabo+ueYTkF5gF1wa2EGyeTwmvpgEMgHCHs/6mEaZ+uqt1HQkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mM1g8WId; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mM1g8WId; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4153335DFA X-Spam-Score: -3.50 X-Migadu-Scanner: scn0.migadu.com X-TUID: sX5tJGR5D/ky Hi Justin, Justin Veilleux skribis: > I realize that this change isn't trivial as it breaks some people's > os.scm and requires updating the documentation, but I think it is a > very low hanging fruit in terms of functionality. I think the risk of breakage is low: the previous extension mechanism had only one use case, qemu-binfmt. That use case is now gone, so we should be fine. > +(define-record-type* > + guix-extension make-guix-extension > + guix-extension? > + (authorized-keys guix-extension-authorized-keys ;list of gexps > + (default '())) > + (substitute-urls guix-extension-substitute-urls ;list of strings > + (default '())) > + (chroot-directories guix-extension-chroot-directories ;list of file-li= ke/strings > + (default '()))) I like this approach! Together with update documentation and a changelog, it LGTM. Could you send an updated patch? Thanks, Ludo=E2=80=99.