From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: 63545@debbugs.gnu.org
Cc: Felix Lechner <felix.lechner@lease-up.com>
Subject: [bug#63545] [PATCH 1/3] gnu: heimdal: Build from Git.
Date: Wed, 17 May 2023 22:20:19 +0200 [thread overview]
Message-ID: <87wn161zi4.fsf@jpoiret.xyz> (raw)
In-Reply-To: <2262ef65f5191b0c3d925ea6688c1bd8bf0587d0.1684296904.git.felix.lechner@lease-up.com>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
Hi Felix,
I am no user of Heimdal, but this looks good to me apart from some
nitpicks below.
Felix Lechner via Guix-patches via <guix-patches@gnu.org> writes:
> (define-public heimdal
> + (let ((commit "a6cf94577c0d1e5bca5304342e4ddffb18255afe")
> + (revision "1"))
No need to use commit+revision for fixed releases, unless upstream has
the bad habit of moving their upstream tags. I see the tag
heimdal-7.8.0, which you should use in (commit ...), possibly with
(commit (string-append "heimdall-" version)).
> (package
> (name "heimdal")
> - (version "7.8.0")
> + (version (git-version "7.8.0" revision commit))
This would lead to a very ugly version string for what is actually
7.8.0, no need to change this.
The other patches seem fine, although I think you don't need to go as
far as make the indentation change its own patch (and by dropping the
commit+revision thing, there shouldn't be one).
I haven't tried building this yet though, will let QA go over it.
Best,
--
Josselin Poiret
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]
next prev parent reply other threads:[~2023-05-17 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 4:19 [bug#63545] [PATCH 0/3] gnu: heimdal: Drop obsolete user tools Felix Lechner via Guix-patches via
2023-05-17 4:20 ` [bug#63545] [PATCH 1/3] gnu: heimdal: Build from Git Felix Lechner via Guix-patches via
2023-05-17 20:20 ` Josselin Poiret via Guix-patches via [this message]
2023-05-17 4:20 ` [bug#63545] [PATCH 2/3] gnu: heimdal: Drop obsolete and insecure user tools Felix Lechner via Guix-patches via
2023-05-17 4:20 ` [bug#63545] [PATCH 3/3] gnu: heimdal: Re-indent code; no functional change Felix Lechner via Guix-patches via
2023-05-29 0:19 ` [bug#63545] [PATCH v2 1/2] gnu: heimdal: Run autoreconf Felix Lechner via Guix-patches via
2023-05-29 0:19 ` [bug#63545] [PATCH v2 2/2] gnu: heimdal: Drop obsolete and insecure user tools Felix Lechner via Guix-patches via
2023-06-04 9:39 ` bug#63545: [PATCH v2 1/2] gnu: heimdal: Run autoreconf Josselin Poiret via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn161zi4.fsf@jpoiret.xyz \
--to=guix-patches@gnu.org \
--cc=63545@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=felix.lechner@lease-up.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.