From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0JF3EkA3ZWTN4wAASxT56A (envelope-from ) for ; Wed, 17 May 2023 22:21:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iM9FEkA3ZWRZmAAAauVa8A (envelope-from ) for ; Wed, 17 May 2023 22:21:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B84003C72C for ; Wed, 17 May 2023 22:21:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzNdw-0000Gi-6E; Wed, 17 May 2023 16:21:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzNdv-0000GJ-0z for guix-patches@gnu.org; Wed, 17 May 2023 16:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzNdu-0005Rm-Gc for guix-patches@gnu.org; Wed, 17 May 2023 16:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzNdu-000812-9V for guix-patches@gnu.org; Wed, 17 May 2023 16:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH 1/3] gnu: heimdal: Build from Git. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 May 2023 20:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Felix Lechner X-Debbugs-Original-To: Felix Lechner via Guix-patches via , 63545@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168435483330734 (code B ref -1); Wed, 17 May 2023 20:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 May 2023 20:20:33 +0000 Received: from localhost ([127.0.0.1]:51172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzNdQ-0007ze-Uu for submit@debbugs.gnu.org; Wed, 17 May 2023 16:20:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:54930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzNdP-0007zV-6t for submit@debbugs.gnu.org; Wed, 17 May 2023 16:20:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzNdO-0000Au-C9 for guix-patches@gnu.org; Wed, 17 May 2023 16:20:31 -0400 Received: from jpoiret.xyz ([206.189.101.64]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzNdM-0005Jn-Sd for guix-patches@gnu.org; Wed, 17 May 2023 16:20:30 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 7D48A18530D; Wed, 17 May 2023 20:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1684354825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p5A0L66GFgIOHmymMQFCcFETUk8C12wcJn1uuvPMoJA=; b=b2fWwJQ9ysUuY2BxWVJhkAtN6CKhiAevMD5xKhtbAgws2o+kC/81RFUBj+khr5L61U7Ckj l0H+2McVlVMaTlScETp02Z6XUMUE4VnmEF79bpxjpCuRMUUojOMVNOiRiuFe23/z8/KBoM GTj6EcTJrtpOIWT4rffQqhCA+vZDjizADJOW0Xm+4VNGPqs0EUiFAr0X5KSrkDjDhPLvK2 93XkJ8Yngdauft1XuSFWbzAlU45apEeuVsai9iXtCYfjlCCoR3WoAQcvNNa0c89KH5Hy2S 3Z+zN8Dmxu5t5B2brfO8lLLgmWpZHkCJ7bbrw4fp5MNWrp3GtAxQnhI+SKjGQA== In-Reply-To: <2262ef65f5191b0c3d925ea6688c1bd8bf0587d0.1684296904.git.felix.lechner@lease-up.com> References: <2262ef65f5191b0c3d925ea6688c1bd8bf0587d0.1684296904.git.felix.lechner@lease-up.com> Date: Wed, 17 May 2023 22:20:19 +0200 Message-ID: <87wn161zi4.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684354880; a=rsa-sha256; cv=none; b=oCCkekwPS9gy3k2Om8ekittBgQtQvGWWTeVzQewgATuduke5W5mVZJyvULf9W1ceVADuRc /4LY7kCMjuiN53pZxHvl9Xbq/nO2QXZ+0U7w3aPkAfyK8ukRtn13nv+rI6xy+lcp0UfSrA 32R9VXvP7HMqxsYJb3g72VOqbKhT1WDkwX/dYUm/3F09Aj1OoLDtKLe/5ymmJ98WJN2yI4 Ns92kDDRJ+1xw2hL8iRAQiYH4KchX3YDskusIG99saHmTezogvWTCOsCnQ9MqfbC8UeCVd h4CVOCVzssap0jAJncjSIl+VPDw9y68BYW59m4BGTQEy2itm4Q7fEdstDAnNfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=b2fWwJQ9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684354880; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=p5A0L66GFgIOHmymMQFCcFETUk8C12wcJn1uuvPMoJA=; b=l4jGSxZpJC5RJDdyhnd3F4xr9JQUFfRIBNib077N40oDEiXA2bP2tKn1BoFZb8E/KLw++v tyzf7EVVkRs4cFRhSvLmCuMwDarogKDOxKwATrDPNt8vCha4GwWrnj31Ys60bpGmhg+pyh XtLc7jsgCDz4Yub7zeIT5OOmxdhz8XHFrTFFSzg5SWbq0hS2xJ0aYJrQsrt9Kvh5oS75nT X+GLame51RRDAhIj7It5iK1FRHzM3N58uztkXpi27mXGrH/xUMhwijsPxsoMkQV0+1kV8n bgxupjAQCnILaOl1vrGp3alcx9a/eqZqUx3+CFQ4zM8MrLgsL3RBb13iOU3AoA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=b2fWwJQ9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.99 X-Spam-Score: -3.99 X-Migadu-Queue-Id: B84003C72C X-TUID: ks3H9L+nXNzy --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Felix, I am no user of Heimdal, but this looks good to me apart from some nitpicks below. Felix Lechner via Guix-patches via writes: > (define-public heimdal > + (let ((commit "a6cf94577c0d1e5bca5304342e4ddffb18255afe") > + (revision "1")) No need to use commit+revision for fixed releases, unless upstream has the bad habit of moving their upstream tags. I see the tag heimdal-7.8.0, which you should use in (commit ...), possibly with (commit (string-append "heimdall-" version)). > (package > (name "heimdal") > - (version "7.8.0") > + (version (git-version "7.8.0" revision commit)) This would lead to a very ugly version string for what is actually 7.8.0, no need to change this. The other patches seem fine, although I think you don't need to go as far as make the indentation change its own patch (and by dropping the commit+revision thing, there shouldn't be one). I haven't tried building this yet though, will let QA go over it. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmRlNwMQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcailfQDACcfWKScDjfg6OuiGeMg3ZqKaBfNQxdVA69 7fA8AKeVkD3so4eSR1nxbStNi5tZFHG/wqLHcF5hxMEan7lgJ8n9B0+BiZTOM4BJ 8IB8KkkuDLNmiv2qsv1bQTEvUgR0dsk4N72qn9z46J7ZrIaqoT7XDNKZnZIMxhps Ww8U2j+Yvqx4AxTZPWQo7N1egJKWFj8OhOlM0IU0CU6C+DlQ10eeKfjuePOJOP/Z G1+DF0k9mwWWvSIxHN9uj480IAk42WyvNLXEeq5zOzA2Z+ZYbKAY3eFPkWNqG5F4 TmTdzKlJRmh0jGqj7tb5vipfEvJdxcF5mC7b0GK5eilltg6ApGnXHeyrdqqHwcvU Jws8g0luXwWvUFYwieClmRxdqhDGk4H4In+gVm2Y88B1oQgdg5rlzbYScxCd3l1O e2lR9oio+NyXbj7OeVAVIuDepKyKm1D0a5X98Sq392MDleWxID1RSTm1iDt8tkRV gD7EBprxSzT87n61+WlmcotbcyudbjQ= =j2aT -----END PGP SIGNATURE----- --=-=-=--