From: Ricardo Wurmus <rekado@elephly.net>
To: Theodoros Foradis <theodoros@foradis.org>
Cc: 31531@debbugs.gnu.org
Subject: [bug#31531] [PATCH 1/3] gnu: Add cppzmq.
Date: Mon, 21 May 2018 22:31:48 +0200 [thread overview]
Message-ID: <87vabgoimj.fsf@elephly.net> (raw)
In-Reply-To: <20180519185437.23665-1-theodoros@foradis.org>
Hi Theodoros,
> * gnu/packages/networking.scm (cppzmq): New variable.
Thanks for the patch!
> +(define-public cppzmq
> + (package
> + (name "cppzmq")
> + (version "4.2.2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/zeromq/" name
> + "/archive/v" version ".tar.gz"))
> + (sha256
> + (base32
> + "0zbk3726pvcl088qzl5z3cc0w0k5hh192l5jddnc0xsqmiq01x9y"))
> + (file-name (string-append name "-" version
> ".tar.gz"))))
Please use “git-fetch” here and let the file name end on “-checkout”.
These automatically generated tarballs on GitHub are not stable; they
change over time.
> + (build-system cmake-build-system)
> + (arguments
> + '(#:tests? #f)) ;; No tests.
Please just use a single semicolon for end of line comments. You can
move this expression on the previous line, because it is short.
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("zeromq" ,zeromq)))
> + (home-page "http://zeromq.org")
> + (synopsis "C++ bindings for ØMQ")
> + (description
> + "Header-only C++ bindings for ØMQ. Contains direct mappings of the
> +abstractions provided by the ØMQ C API.")
Please use complete sentences.
Could you please send a new patch?
--
Ricardo
next prev parent reply other threads:[~2018-05-21 20:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 18:50 [bug#31531] Update monero to 0.12.0.0 Theodoros Foradis
2018-05-19 18:54 ` [bug#31531] [PATCH 1/3] gnu: Add cppzmq Theodoros Foradis
2018-05-19 18:54 ` [bug#31531] [PATCH 2/3] gnu: monero: Update to 0.12.0.0 Theodoros Foradis
2018-05-21 20:35 ` Ricardo Wurmus
2018-05-19 18:54 ` [bug#31531] [PATCH 3/3] gnu: monero-core: " Theodoros Foradis
2018-05-21 20:36 ` Ricardo Wurmus
2018-05-21 20:31 ` Ricardo Wurmus [this message]
2018-07-08 17:35 ` [bug#31531] [PATCH 1/3] gnu: Add cppzmq Theodoros Foradis
2018-07-08 17:39 ` [bug#31531] [PATCH v2 1/9] " Theodoros Foradis
2018-07-08 17:39 ` [bug#31531] [PATCH v2 2/9] gnu: Add monero-miniupnpc Theodoros Foradis
2018-07-13 15:30 ` Ludovic Courtès
2018-07-08 17:39 ` [bug#31531] [PATCH v2 3/9] gnu: monero: Update to 0.12.3.0 Theodoros Foradis
2018-07-13 15:31 ` Ludovic Courtès
2018-07-15 11:34 ` Theodoros Foradis
2018-07-16 14:40 ` Ludovic Courtès
2018-07-08 17:39 ` [bug#31531] [PATCH v2 4/9] gnu: monero: Return #t from phases Theodoros Foradis
2018-07-08 17:39 ` [bug#31531] [PATCH v2 5/9] gnu: monero-core: Update to 0.12.2.0 Theodoros Foradis
2018-07-08 17:39 ` [bug#31531] [PATCH v2 6/9] gnu: monero-core: Return #t from phases Theodoros Foradis
2018-07-08 17:39 ` [bug#31531] [PATCH v2 7/9] gnu: monero: Use git-fetch Theodoros Foradis
2018-07-08 17:39 ` [bug#31531] [PATCH v2 8/9] gnu: monero-core: " Theodoros Foradis
2018-07-08 17:39 ` [bug#31531] [PATCH v2 9/9] gnu: monero-core: Rename package to "monero-gui" Theodoros Foradis
2018-07-16 14:52 ` bug#31531: " Ludovic Courtès
2018-07-13 15:29 ` [bug#31531] [PATCH v2 1/9] gnu: Add cppzmq Ludovic Courtès
2018-06-14 20:21 ` [bug#31531] Update monero to 0.12.0.0 Ludovic Courtès
2018-07-04 16:36 ` Theodoros Foradis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vabgoimj.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=31531@debbugs.gnu.org \
--cc=theodoros@foradis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.