From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fKrUP-0004m7-TE
	for guix-patches@gnu.org; Mon, 21 May 2018 16:33:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fKrUL-0004Oa-VE
	for guix-patches@gnu.org; Mon, 21 May 2018 16:33:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35365)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fKrUL-0004OQ-So
	for guix-patches@gnu.org; Mon, 21 May 2018 16:33:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fKrUL-0000KU-Jk
	for guix-patches@gnu.org; Mon, 21 May 2018 16:33:01 -0400
Subject: [bug#31531] [PATCH 1/3] gnu: Add cppzmq.
Resent-Message-ID: <handler.31531.B31531.15269347421220@debbugs.gnu.org>
References: <87bmdbtr7p.fsf@foradis.org>
	<20180519185437.23665-1-theodoros@foradis.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20180519185437.23665-1-theodoros@foradis.org>
Date: Mon, 21 May 2018 22:31:48 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <87vabgoimj.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Theodoros Foradis <theodoros@foradis.org>
Cc: 31531@debbugs.gnu.org


Hi Theodoros,

> * gnu/packages/networking.scm (cppzmq): New variable.

Thanks for the patch!

> +(define-public cppzmq
> +  (package
> +    (name "cppzmq")
> +    (version "4.2.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/zeromq/" name
> +                    "/archive/v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0zbk3726pvcl088qzl5z3cc0w0k5hh192l5jddnc0xsqmiq01x9y"))
> +              (file-name (string-append name "-" version
> ".tar.gz"))))

Please use =E2=80=9Cgit-fetch=E2=80=9D here and let the file name end on =
=E2=80=9C-checkout=E2=80=9D.
These automatically generated tarballs on GitHub are not stable; they
change over time.

> +    (build-system cmake-build-system)
> +    (arguments
> +     '(#:tests? #f)) ;; No tests.

Please just use a single semicolon for end of line comments.  You can
move this expression on the previous line, because it is short.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("zeromq" ,zeromq)))
> +    (home-page "http://zeromq.org")
> +    (synopsis "C++ bindings for =C3=98MQ")
> +    (description
> +     "Header-only C++ bindings for =C3=98MQ.  Contains direct mappings o=
f the
> +abstractions provided by the =C3=98MQ C API.")

Please use complete sentences.

Could you please send a new patch?

--=20
Ricardo