From: "Ludovic Courtès" <ludo@gnu.org>
To: Andy Wingo <wingo@igalia.com>
Cc: 27476@debbugs.gnu.org
Subject: bug#27476: libguile/memoize.c is not thread safe, so syntax parameter expansion is not thread-safe
Date: Wed, 06 Feb 2019 23:09:23 +0100 [thread overview]
Message-ID: <87va1w6030.fsf@gnu.org> (raw)
In-Reply-To: <87o97o99n6.fsf@igalia.com> (Andy Wingo's message of "Wed, 06 Feb 2019 17:14:37 +0100")
Hi!
Andy Wingo <wingo@igalia.com> skribis:
> To be clear, here's the series of events. Firstly, know that defining a
> syntax parameter is like:
Thanks for the clear explanation!
>> So I came up with ‘define-syntax-parameter-once’, which is like
>> ‘define-once’ but for syntax parameters (note that we can’t use
>> ‘define-once’ in ‘define-syntax-parameter-once’ because it expands to a
>> reference to NAME, which doesn’t work for a macro):
>
> Your fix is good! But, it prevents redefinition of syntax parameters.
Yes. It’s acceptable in this case, so I’ve pushed it as a workaround as
commit 8245bb74fc7bdcdc2f9d458057cefc9cd982e489 in Guix.
> I would like to work on a solution that instead of using this
> double-lookup, simply adds an association between P and F* in the
> environment, instead of doing the double-lookup thing. Probably that
> will be 3.0-only.
>
> For 2.2, we can probably update the compiler to trampoline through some
> kind of "redefine-syntax" or something that will do (set-car! B F**)
> instead of (define P (stx-param B*)). I.e. redefinition keeps the
> unique key there.
Sounds good. Are you taking a look at this?
Perhaps that’d be a good excuse to release 2.2.5.
Thank you!
Ludo’.
next prev parent reply other threads:[~2019-02-06 22:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:38 guix pull fails on powerful server Ricardo Wurmus
2017-09-22 14:10 ` bug#27476: " Ludovic Courtès
2017-09-25 7:27 ` Andy Wingo
2017-09-25 13:03 ` Ludovic Courtès
2017-09-25 14:02 ` bug#27476: " Ricardo Wurmus
2017-09-30 7:59 ` Ricardo Wurmus
2017-10-03 20:29 ` Marius Bakke
2017-10-04 13:15 ` Ricardo Wurmus
2017-10-04 13:15 ` bug#27476: " Ricardo Wurmus
2017-10-03 20:29 ` Marius Bakke
2017-10-04 15:09 ` Clément Lassieur
2017-10-04 16:17 ` bug#27476: " Ricardo Wurmus
2017-10-04 15:09 ` Clément Lassieur
2017-10-07 15:11 ` Ludovic Courtès
2017-10-07 15:11 ` Ludovic Courtès
2017-10-10 7:17 ` bug#27476: " Ricardo Wurmus
2017-10-10 7:17 ` Ricardo Wurmus
2017-10-10 11:32 ` bug#27476: " Ludovic Courtès
2017-10-10 11:32 ` Ludovic Courtès
2017-10-12 13:37 ` bug#27476: " Ludovic Courtès
2017-10-13 20:29 ` Ricardo Wurmus
2017-10-13 20:29 ` Ricardo Wurmus
2017-10-13 21:04 ` Ricardo Wurmus
2017-10-13 21:10 ` Ricardo Wurmus
2017-10-12 13:37 ` Ludovic Courtès
2017-11-07 10:57 ` Ludovic Courtès
2018-04-30 21:19 ` Ludovic Courtès
2018-04-30 21:39 ` bug#27476: libguile/memoize.c is not thread safe, so syntax parameter expansion is not thread-safe Ludovic Courtès
2018-05-09 8:41 ` Andy Wingo
2018-05-09 9:23 ` Ludovic Courtès
2018-05-09 10:18 ` Andy Wingo
2019-02-06 14:48 ` Ludovic Courtès
2019-02-06 16:14 ` Andy Wingo
2019-02-06 22:09 ` Ludovic Courtès [this message]
2019-01-29 10:07 ` bug#27476: guix pull fails on powerful server Ricardo Wurmus
2019-01-29 10:07 ` Ricardo Wurmus
2017-11-07 10:57 ` Ludovic Courtès
2017-09-30 7:59 ` Ricardo Wurmus
2017-09-25 13:03 ` Ludovic Courtès
2017-09-25 8:43 ` Clément Lassieur
2017-09-25 8:43 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va1w6030.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27476@debbugs.gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.