From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Andy Wingo <wingo@igalia.com>, 27476@debbugs.gnu.org
Subject: bug#27476: libguile/memoize.c is not thread safe, so syntax parameter expansion is not thread-safe
Date: Mon, 30 Apr 2018 23:39:05 +0200 [thread overview]
Message-ID: <874ljstlvq.fsf_-_@gnu.org> (raw)
In-Reply-To: <87h8nstms1.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 30 Apr 2018 23:19:42 +0200")
ludo@gnu.org (Ludovic Courtès) skribis:
> With Guile 2.2.3 a similar program triggers a crash very quickly:
Even simpler:
--8<---------------cut here---------------start------------->8---
$ guile ../guile-debugging/syntax-parms.scm
;;; note: source file /home/ludo/src/guix/../guile-debugging/syntax-parms.scm
;;; newer than compiled /home/ludo/.cache/guile/ccache/2.2-LE-8-3.A/home/ludo/src/guile-debugging/syntax-parms.scm.go
;;; note: auto-compilation is enabled, set GUILE_AUTO_COMPILE=0
;;; or pass the --no-auto-compile argument to disable.
;;; compiling /home/ludo/src/guix/../guile-debugging/syntax-parms.scm
;;; compiled /home/ludo/.cache/guile/ccache/2.2-LE-8-3.A/home/ludo/src/guile-debugging/syntax-parms.scm.go
In /home/ludo/src/guix/../guile-debugging/syntax-parms.scm:
37:17 13 (_)
In system/base/compile.scm:
255:6 12 (compile _ #:from _ #:to _ #:env _ #:opts _)
183:32 11 (compile-fold (#f syntax-violation (#<tree-il (const #f)> #<tree-il (const "source expression failed to match any pattern")> #<tree-il (lexical tmp tmp-1dff1b…>)) # …)
In ice-9/boot-9.scm:
2312:4 10 (save-module-excursion #<procedure 57dd920 at ice-9/psyntax.scm:1774:12 (a b)>)
In language/scheme/compile-tree-il.scm:
31:15 9 (_)
In ice-9/psyntax.scm:
1234:22 8 (expand-top-sequence (#<tree-il (primcall syntax-violation (const #f) (const "source expression failed to match any pattern") (lexical tmp tmp-1dff1b83541ce327-2…>) …)
In ice-9/boot-9.scm:
222:29 7 (map1 ((10 (3 #((0 . 0)) 2 (1 (11 0 . 0) (7 (3 #() 2 (10 (13 15 5 (guile) list . #f) (5 . #<syntax ->) (11 0 . 0) (11 0 . 1)) () 2) (11 0 . 0)) 10 (. #) …) …) #) …))
222:17 6 (map1 (10 (3 #((0 . 0)) 2 (1 (11 0 . 0) (7 (3 #() 2 (10 (13 15 5 (guile) list . #f) (5 . #<syntax ->) (11 0 . 0) (11 0 . 1)) () 2) (11 0 . 0)) 10 (13 # . #) …) …) …))
In ice-9/psyntax.scm:
2054:19 5 (_ _ (#<tree-il (const (_ any any))>) (param 1 2) ())
In ice-9/boot-9.scm:
222:17 4 (map1 (#<tree-il (const (_ any any))>))
In ice-9/psyntax.scm:
2057:27 3 (_ _)
289:10 2 (eval-local-transformer _ _)
In ice-9/eval.scm:
718:15 1 (primitive-eval _)
In unknown file:
0 (memoize-expression #<tree-il (lambda () (lambda-case (((() 1) #f #f #f () ((11 0 . 0))) (call (lambda () (lambda-case ((((#f . #(tmp-1dff1b83541ce327-248119)) (#t…>)
ERROR: In procedure memoize-expression:
In procedure vector: Wrong type argument in position 1: #(#<directory (guile-user) cd8140>)
C-c C-c
$ cat ../guile-debugging/syntax-parms.scm
(use-modules (ice-9 threads)
(srfi srfi-1)
(system base compile))
(compile #f) ;load modules
(define-syntax-parameter param
(lambda (s)
(syntax-case s ()
((_ a b) #'(+ a b)))))
(define threads
(unfold (lambda (x) (> x 100))
(lambda (x)
(call-with-new-thread
(lambda ()
(while #t
(compile '(begin
(param 1 2)
(syntax-parameterize ((param (lambda (s)
(syntax-case s ()
((_ a b)
#'(- a b))))))
(param 1 2)))
#:env (current-module)
#:from 'scheme
#:to 'tree-il)))))
1+
0))
(for-each join-thread threads)
--8<---------------cut here---------------end--------------->8---
So the problem, AIUI, is that psyntax evaluates syntax parameters using
‘primitive-eval’ (via ‘eval-local-transformer’), but memoization in
(ice-9 eval) is not thread-safe, hence the random crashes.
Not sure what can be done. Thoughts?
Ludo’.
next prev parent reply other threads:[~2018-04-30 21:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:38 guix pull fails on powerful server Ricardo Wurmus
2017-09-22 14:10 ` bug#27476: " Ludovic Courtès
2017-09-25 7:27 ` Andy Wingo
2017-09-25 13:03 ` Ludovic Courtès
2017-09-25 14:02 ` bug#27476: " Ricardo Wurmus
2017-09-30 7:59 ` Ricardo Wurmus
2017-10-03 20:29 ` bug#27476: " Marius Bakke
2017-10-03 20:29 ` Marius Bakke
2017-10-04 13:15 ` bug#27476: " Ricardo Wurmus
2017-10-04 13:15 ` Ricardo Wurmus
2017-10-04 15:09 ` bug#27476: " Clément Lassieur
2017-10-04 15:09 ` Clément Lassieur
2017-10-04 16:17 ` bug#27476: " Ricardo Wurmus
2017-10-07 15:11 ` Ludovic Courtès
2017-10-10 7:17 ` Ricardo Wurmus
2017-10-10 11:32 ` Ludovic Courtès
2017-10-10 11:32 ` bug#27476: " Ludovic Courtès
2017-10-10 7:17 ` Ricardo Wurmus
2017-10-07 15:11 ` Ludovic Courtès
2017-10-12 13:37 ` Ludovic Courtès
2017-10-12 13:37 ` Ludovic Courtès
2017-10-13 20:29 ` Ricardo Wurmus
2017-10-13 20:29 ` Ricardo Wurmus
2017-10-13 21:04 ` Ricardo Wurmus
2017-10-13 21:10 ` Ricardo Wurmus
2017-11-07 10:57 ` Ludovic Courtès
2017-11-07 10:57 ` Ludovic Courtès
2018-04-30 21:19 ` Ludovic Courtès
2018-04-30 21:39 ` Ludovic Courtès [this message]
2018-05-09 8:41 ` bug#27476: libguile/memoize.c is not thread safe, so syntax parameter expansion is not thread-safe Andy Wingo
2018-05-09 9:23 ` Ludovic Courtès
2018-05-09 10:18 ` Andy Wingo
2019-02-06 14:48 ` Ludovic Courtès
2019-02-06 16:14 ` Andy Wingo
2019-02-06 22:09 ` Ludovic Courtès
2019-01-29 10:07 ` bug#27476: guix pull fails on powerful server Ricardo Wurmus
2019-01-29 10:07 ` Ricardo Wurmus
2017-09-30 7:59 ` Ricardo Wurmus
2017-09-25 13:03 ` Ludovic Courtès
2017-09-25 8:43 ` Clément Lassieur
2017-09-25 8:43 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ljstlvq.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=27476@debbugs.gnu.org \
--cc=rekado@elephly.net \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.