From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 34758@debbugs.gnu.org
Subject: [bug#34758] [PATCH 1/4] gnu: Add libmirage.
Date: Fri, 22 Mar 2019 22:10:41 +0100 [thread overview]
Message-ID: <87va0a399q.fsf@gnu.org> (raw)
In-Reply-To: <20190305172620.20118-1-mail@ambrevar.xyz> (Pierre Neidhardt's message of "Tue, 5 Mar 2019 18:26:20 +0100")
Hello Pierre,
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
> * gnu/packages/cdrom.scm (libmirage): New variable.
[...]
> + (uri (string-append
> + "https://downloads.sourceforge.net/cdemu/libmirage-"
Please use mirror://sourceforge instead (in the other patches as well).
> + (home-page "https://cdemu.sourceforge.io/")
> + (synopsis "CD-ROM image (B6T/C2D/CCD/CDI/CIF/CUE/ISO/MDS/MDX/NRG/TOC) access library")
I’d remove the list that’s in parentheses here.
Otherwise LGTM, thanks!
Ludo’.
prev parent reply other threads:[~2019-03-22 21:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 17:26 [bug#34758] [PATCH 1/4] gnu: Add libmirage Pierre Neidhardt
2019-03-05 17:28 ` [bug#34758] [PATCH 2/4] gnu: Add vhba Pierre Neidhardt
2019-03-05 17:28 ` [bug#34758] [PATCH 3/4] gnu: Add cdemu-daemon Pierre Neidhardt
2019-03-22 21:13 ` Ludovic Courtès
2019-03-05 17:28 ` [bug#34758] [PATCH 4/4] gnu: Add cdemu-client Pierre Neidhardt
2019-03-22 21:14 ` Ludovic Courtès
2019-03-22 21:25 ` Pierre Neidhardt
2019-03-22 21:12 ` [bug#34758] [PATCH 2/4] gnu: Add vhba Ludovic Courtès
2019-03-22 21:24 ` Pierre Neidhardt
2019-03-22 21:27 ` Pierre Neidhardt
2019-03-23 14:52 ` Ludovic Courtès
2019-03-25 8:35 ` Pierre Neidhardt
2019-03-25 21:10 ` Ludovic Courtès
[not found] ` <handler.34758.B.15518068039570.ack@debbugs.gnu.org>
2019-03-05 17:44 ` [bug#34758] Acknowledgement ([PATCH 1/4] gnu: Add libmirage.) Pierre Neidhardt
2019-03-22 21:10 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va0a399q.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34758@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.