From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:33417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7RcE-0000HP-Gs
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:22:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7RVN-0001Yy-2r
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:15:10 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41199)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h7RVH-0001V1-6U
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:15:07 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7RVH-0000Y8-1S
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:15:03 -0400
Subject: [bug#34758] [PATCH 1/4] gnu: Add libmirage.
Resent-Message-ID: <handler.34758.B34758.15532892692012@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190305172620.20118-1-mail@ambrevar.xyz>
Date: Fri, 22 Mar 2019 22:10:41 +0100
In-Reply-To: <20190305172620.20118-1-mail@ambrevar.xyz> (Pierre Neidhardt's
	message of "Tue, 5 Mar 2019 18:26:20 +0100")
Message-ID: <87va0a399q.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 34758@debbugs.gnu.org

Hello Pierre,

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> * gnu/packages/cdrom.scm (libmirage): New variable.

[...]

> +              (uri (string-append
> +                    "https://downloads.sourceforge.net/cdemu/libmirage-"

Please use mirror://sourceforge instead (in the other patches as well).

> +    (home-page "https://cdemu.sourceforge.io/")
> +    (synopsis "CD-ROM image (B6T/C2D/CCD/CDI/CIF/CUE/ISO/MDS/MDX/NRG/TOC=
) access library")

I=E2=80=99d remove the list that=E2=80=99s in parentheses here.

Otherwise LGTM, thanks!

Ludo=E2=80=99.