all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#36607] [PATCH 0/2] Add pngquant and libimagequant required by it.
@ 2019-07-11 20:29 Hartmut Goebel
  2019-07-11 20:39 ` Hartmut Goebel
  0 siblings, 1 reply; 7+ messages in thread
From: Hartmut Goebel @ 2019-07-11 20:29 UTC (permalink / raw)
  To: 36607

Add pngquant and libimagequant required by it.

Hartmut Goebel (2):
  gnu: Add libimagequant.
  gnu: Add pngquant.

 gnu/packages/image.scm | 68 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 67 insertions(+), 1 deletion(-)

-- 
2.21.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#36607] [PATCH 0/2] Add pngquant and libimagequant required by it.
  2019-07-11 20:29 [bug#36607] [PATCH 0/2] Add pngquant and libimagequant required by it Hartmut Goebel
@ 2019-07-11 20:39 ` Hartmut Goebel
  2019-07-11 20:39   ` [bug#36607] [PATCH 1/2] gnu: Add libimagequant Hartmut Goebel
  2019-07-11 20:39   ` [bug#36607] [PATCH 2/2] gnu: Add pngquant Hartmut Goebel
  0 siblings, 2 replies; 7+ messages in thread
From: Hartmut Goebel @ 2019-07-11 20:39 UTC (permalink / raw)
  To: 36607

Add pngquant and libimagequant required by it.

Hartmut Goebel (2):
  gnu: Add libimagequant.
  gnu: Add pngquant.

 gnu/packages/image.scm | 68 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 67 insertions(+), 1 deletion(-)

-- 
2.21.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#36607] [PATCH 1/2] gnu: Add libimagequant.
  2019-07-11 20:39 ` Hartmut Goebel
@ 2019-07-11 20:39   ` Hartmut Goebel
  2019-07-13 12:52     ` Ludovic Courtès
  2019-07-11 20:39   ` [bug#36607] [PATCH 2/2] gnu: Add pngquant Hartmut Goebel
  1 sibling, 1 reply; 7+ messages in thread
From: Hartmut Goebel @ 2019-07-11 20:39 UTC (permalink / raw)
  To: 36607

* gnu/packages/image.scm (libimagequant): New variable.
---
 gnu/packages/image.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index fabc2fb2d1..5a5174354c 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2016, 2017 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2016, 2017 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2017 ng0 <ng0@n0.is>
-;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2017,2019 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;; Copyright © 2017 Julien Lepiller <julien@lepiller.eu>
 ;;; Copyright © 2018 Joshua Sierles, Nextjournal <joshua@nextjournal.com>
 ;;; Copyright © 2018 Fis Trivial <ybbs.daans@hotmail.com>
@@ -313,6 +313,28 @@ files.  It can compress them as much as 40% losslessly.")
 Currently all documentation resides in @file{pnglite.h}.")
       (license license:zlib))))
 
+(define-public libimagequant
+  (package
+   (name "libimagequant")
+   (version "2.12.3")
+   (source
+    (origin
+      (method git-fetch)
+      (uri (git-reference
+            (url "https://github.com/ImageOptim/libimagequant.git")
+            (commit version)))
+      (file-name (git-file-name name version))
+      (sha256
+       (base32 "0qsfq1kv1m5jzn9v9iz0bac66k4clcis1c9877qabnwzwmwma5v0"))))
+   (build-system gnu-build-system)
+   (arguments
+    '(#:tests? #f)) ; no check target
+   (home-page "https://pngquant.org/lib/")
+   (synopsis "Image palette quantization library")
+   (description "Small, portable C library for high-quality conversion of RGBA
+images to 8-bit indexed-color (palette) images.")
+   (license license:gpl3)))
+
 (define-public libjpeg
   (package
    (name "libjpeg")
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#36607] [PATCH 2/2] gnu: Add pngquant.
  2019-07-11 20:39 ` Hartmut Goebel
  2019-07-11 20:39   ` [bug#36607] [PATCH 1/2] gnu: Add libimagequant Hartmut Goebel
@ 2019-07-11 20:39   ` Hartmut Goebel
  2019-07-13 12:53     ` Ludovic Courtès
  1 sibling, 1 reply; 7+ messages in thread
From: Hartmut Goebel @ 2019-07-11 20:39 UTC (permalink / raw)
  To: 36607

* gnu/packages/image.scm (pngquant): New variable.
---
 gnu/packages/image.scm | 44 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 5a5174354c..bfbf7ea823 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -335,6 +335,50 @@ Currently all documentation resides in @file{pnglite.h}.")
 images to 8-bit indexed-color (palette) images.")
    (license license:gpl3)))
 
+(define-public pngquant
+  (package
+   (name "pngquant")
+   (version "2.12.3")
+   (source
+    (origin
+      (method git-fetch)
+      (uri (git-reference
+            (url "https://github.com/kornelski/pngquant.git")
+            (commit version)))
+      (file-name (git-file-name name version))
+      (sha256
+       (base32 "1yiwbcihn4311fpfd568gg8zmmhqwg80jmhbhkb5msiipgd9xv33"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:test-target "test"
+      #:configure-flags
+      '("--with-openmp" "--with-lcms2")))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (inputs
+    `(("libpng" ,libpng)
+      ("zlib" , zlib)
+      ("lcms" ,lcms)
+      ("libimagequant" ,libimagequant)))
+   (home-page "https://pngquant.org/")
+   (synopsis "Utility and library for lossy compressing PNG images")
+   (description "pngquant is a PNG compressor that significantly reduces file
+sizes by converting images to a more efficient 8-bit PNG format with alpha
+channel (often 60-80% smaller than 24/32-bit PNG files).  Compressed images
+are fully standards-compliant and are supported by all web browsers and
+operating systems.
+
+Features:
+@enumerate
+@item High-quality palette generation using a combination of vector
+      quantization algorithms.
+@item Unique adaptive dithering algorithm that adds less noise to images
+      than the standard Floyd-Steinberg.
+@item Easy to integrate with shell scripts, GUIs and server-side software.
+@item Fast mode for real-time processing/large numbers of images.
+@end enumerate")
+   (license license:gpl3)))
+
 (define-public libjpeg
   (package
    (name "libjpeg")
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#36607] [PATCH 1/2] gnu: Add libimagequant.
  2019-07-11 20:39   ` [bug#36607] [PATCH 1/2] gnu: Add libimagequant Hartmut Goebel
@ 2019-07-13 12:52     ` Ludovic Courtès
  2019-07-13 18:06       ` bug#36607: " Hartmut Goebel
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2019-07-13 12:52 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 36607

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/image.scm (libimagequant): New variable.
> +(define-public libimagequant
> +  (package
> +   (name "libimagequant")
      ^
Nitpick: fields should be one column further to the right.  (Maybe just
run ./etc/indent-code.el.)

> +   (home-page "https://pngquant.org/lib/")
> +   (synopsis "Image palette quantization library")
> +   (description "Small, portable C library for high-quality conversion of RGBA
> +images to 8-bit indexed-color (palette) images.")

Please write a full sentence (or two :-)).

> +   (license license:gpl3)))

It should be ‘gpl3+’ per ‘COPYRIGHT’.

OK to push with these changes, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#36607] [PATCH 2/2] gnu: Add pngquant.
  2019-07-11 20:39   ` [bug#36607] [PATCH 2/2] gnu: Add pngquant Hartmut Goebel
@ 2019-07-13 12:53     ` Ludovic Courtès
  0 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2019-07-13 12:53 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 36607

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/image.scm (pngquant): New variable.
> +(define-public pngquant
> +  (package
> +   (name "pngquant")
      ^
Missing space.  :-)

> +   (license license:gpl3)))

This one’s also ‘gpl3+’.

OK with these changes, thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#36607: [PATCH 1/2] gnu: Add libimagequant.
  2019-07-13 12:52     ` Ludovic Courtès
@ 2019-07-13 18:06       ` Hartmut Goebel
  0 siblings, 0 replies; 7+ messages in thread
From: Hartmut Goebel @ 2019-07-13 18:06 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 36607-close

Thansk for the review. Fixed and pushe as
6b61dea3365e8cbb6d5a918df5288489e27854e2

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-07-13 18:07 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-11 20:29 [bug#36607] [PATCH 0/2] Add pngquant and libimagequant required by it Hartmut Goebel
2019-07-11 20:39 ` Hartmut Goebel
2019-07-11 20:39   ` [bug#36607] [PATCH 1/2] gnu: Add libimagequant Hartmut Goebel
2019-07-13 12:52     ` Ludovic Courtès
2019-07-13 18:06       ` bug#36607: " Hartmut Goebel
2019-07-11 20:39   ` [bug#36607] [PATCH 2/2] gnu: Add pngquant Hartmut Goebel
2019-07-13 12:53     ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.