* bug#44593: (guix git) doesn’t honor HTTP/HTTPS proxy settings for submodules
@ 2020-11-12 14:01 Ludovic Courtès
2021-01-29 15:06 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2020-11-12 14:01 UTC (permalink / raw)
To: 44593
(guix git) does not honor proxy settings when fetching submodules.
In fact, Guile-Git 0.4.0 doesn’t allow us to pass fetch options to
‘submodule-update’, which is what needs to be fixed first.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#44593: (guix git) doesn’t honor HTTP/HTTPS proxy settings for submodules
2020-11-12 14:01 bug#44593: (guix git) doesn’t honor HTTP/HTTPS proxy settings for submodules Ludovic Courtès
@ 2021-01-29 15:06 ` Ludovic Courtès
2021-04-02 9:56 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2021-01-29 15:06 UTC (permalink / raw)
To: 44593
Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
> (guix git) does not honor proxy settings when fetching submodules.
>
> In fact, Guile-Git 0.4.0 doesn’t allow us to pass fetch options to
> ‘submodule-update’, which is what needs to be fixed first.
Implemented here:
https://gitlab.com/guile-git/guile-git/-/commit/6c512f7a4d14814a306b9c97b53373527d9a6c50
Unfortunately I couldn’t come up with a good test to ensure the fetch
options are honored by ‘submodule-update’, as noted there.
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#44593: (guix git) doesn’t honor HTTP/HTTPS proxy settings for submodules
2021-01-29 15:06 ` Ludovic Courtès
@ 2021-04-02 9:56 ` Ludovic Courtès
2021-04-14 20:52 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2021-04-02 9:56 UTC (permalink / raw)
To: 44593
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
> Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
>
>> (guix git) does not honor proxy settings when fetching submodules.
>>
>> In fact, Guile-Git 0.4.0 doesn’t allow us to pass fetch options to
>> ‘submodule-update’, which is what needs to be fixed first.
>
> Implemented here:
>
> https://gitlab.com/guile-git/guile-git/-/commit/6c512f7a4d14814a306b9c97b53373527d9a6c50
>
> Unfortunately I couldn’t come up with a good test to ensure the fetch
> options are honored by ‘submodule-update’, as noted there.
And here’s the (guix git) patch, to commit when the new Guile-Git
release is out.
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1857 bytes --]
diff --git a/guix/git.scm b/guix/git.scm
index 1820036f25..ed00a50df9 100644
--- a/guix/git.scm
+++ b/guix/git.scm
@@ -279,13 +279,15 @@ dynamic extent of EXP."
(report-git-error err))))
(define* (update-submodules repository
- #:key (log-port (current-error-port)))
+ #:key (log-port (current-error-port))
+ (fetch-options #f))
"Update the submodules of REPOSITORY, a Git repository object."
(for-each (lambda (name)
(let ((submodule (submodule-lookup repository name)))
(format log-port (G_ "updating submodule '~a'...~%")
name)
- (submodule-update submodule)
+ (submodule-update submodule
+ #:fetch-options fetch-options)
;; Recurse in SUBMODULE.
(let ((directory (string-append
@@ -293,6 +295,7 @@ dynamic extent of EXP."
"/" (submodule-path submodule))))
(with-repository directory repository
(update-submodules repository
+ #:fetch-options fetch-options
#:log-port log-port)))))
(repository-submodules repository)))
@@ -391,7 +394,8 @@ it unchanged."
(remote-fetch (remote-lookup repository "origin")
#:fetch-options (make-default-fetch-options)))
(when recursive?
- (update-submodules repository #:log-port log-port))
+ (update-submodules repository #:log-port log-port
+ #:fetch-options (make-default-fetch-options)))
;; Note: call 'commit-relation' from here because it's more efficient
;; than letting users re-open the checkout later on.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#44593: (guix git) doesn’t honor HTTP/HTTPS proxy settings for submodules
2021-04-02 9:56 ` Ludovic Courtès
@ 2021-04-14 20:52 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2021-04-14 20:52 UTC (permalink / raw)
To: 44593-done
Ludovic Courtès <ludo@gnu.org> skribis:
> And here’s the (guix git) patch, to commit when the new Guile-Git
> release is out.
Pushed as fab8ab7617d4ba2eed4546e81b004ade5b739691.
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-14 20:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 14:01 bug#44593: (guix git) doesn’t honor HTTP/HTTPS proxy settings for submodules Ludovic Courtès
2021-01-29 15:06 ` Ludovic Courtès
2021-04-02 9:56 ` Ludovic Courtès
2021-04-14 20:52 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.