From: Brian Cully via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: glv@posteo.net, 62699@debbugs.gnu.org
Subject: [bug#62699] [PATCH] services: add pam-mount-volume-service-type
Date: Tue, 20 Jun 2023 10:14:59 -0400 [thread overview]
Message-ID: <87v8ficj1y.fsf@psyduck.jhoto.kublai.com> (raw)
In-Reply-To: <87352opiw9.fsf_-_@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Nitpick: for new files like ‘pam-mount.scm’ in this case, it’s
> enough to
> write “New file” (relief :-)).
Fixed.
> Please add @* on the previous line to insert a line break.
Fixed. FWIW, I tried looking through the manual (both Guix' and
TexInfo's) to see what this sigil meant, I couldn't figure it out,
so I just guessed. Is this documented somewhere?
> Use the term “pair” rather than “cons cell” (throughout the
> section),
> for consistency with the rest of the manual and to make it more
> approachable.
Fixed.
> How hard would it be to also have a system tests under (gnu
> tests …)?
> Seems like it would better cover functionality.
I'm not sure. I've never done integration tests on an entire
operating system before, so it'd take some doing just to learn the
ropes. I'll go through the existing tests and see what I can come
up with.
Would it be okay to do that as a separate patch, though? Given how
long I expect this work to take, I would like to avoid that extra
delay in having the current patch set (plus the above changes)
committed.
-bjc
next prev parent reply other threads:[~2023-06-20 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 16:43 [bug#62699] [PATCH] services: add pam-mount-volume-service-type Brian Cully via Guix-patches via
2023-04-06 16:57 ` [bug#62699] [PATCH] services: pam-mount: " Brian Cully via Guix-patches via
2023-06-18 21:20 ` [bug#62699] [PATCH] services: " Ludovic Courtès
2023-06-20 14:14 ` Brian Cully via Guix-patches via [this message]
2023-07-18 14:01 ` Brian Cully via Guix-patches via
2023-07-18 14:06 ` [bug#62699] [PATCH v2] " Brian Cully via Guix-patches via
2023-08-09 10:30 ` bug#62699: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8ficj1y.fsf@psyduck.jhoto.kublai.com \
--to=guix-patches@gnu.org \
--cc=62699@debbugs.gnu.org \
--cc=bjc@spork.org \
--cc=glv@posteo.net \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.