From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QJQjK6S1kWR7ZAAASxT56A (envelope-from ) for ; Tue, 20 Jun 2023 16:20:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qMD9KqS1kWTiJwAA9RJhRA (envelope-from ) for ; Tue, 20 Jun 2023 16:20:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 826A63DF4E for ; Tue, 20 Jun 2023 16:20:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBcDJ-0005l6-5d; Tue, 20 Jun 2023 10:20:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBcDD-0005kQ-7F for guix-patches@gnu.org; Tue, 20 Jun 2023 10:20:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBcDC-0002UX-UY for guix-patches@gnu.org; Tue, 20 Jun 2023 10:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBcDC-0001Vd-Lg for guix-patches@gnu.org; Tue, 20 Jun 2023 10:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62699] [PATCH] services: add pam-mount-volume-service-type Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Jun 2023 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62699 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: glv@posteo.net, 62699@debbugs.gnu.org Received: via spool by 62699-submit@debbugs.gnu.org id=B62699.16872708005787 (code B ref 62699); Tue, 20 Jun 2023 14:20:02 +0000 Received: (at 62699) by debbugs.gnu.org; 20 Jun 2023 14:20:00 +0000 Received: from localhost ([127.0.0.1]:59502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBcDA-0001VG-3b for submit@debbugs.gnu.org; Tue, 20 Jun 2023 10:20:00 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:59471 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBcD8-0001V8-Pp for 62699@debbugs.gnu.org; Tue, 20 Jun 2023 10:19:59 -0400 Received: from psyduck (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id 5170EF1B1; Tue, 20 Jun 2023 10:19:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1687270798; bh=GuRGoOLThWVCxY2I+m1km4MiQrAkKzK+nANRfYATnZw=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=cdY+PVX20HLTXhKKU2Vx2PSQPlW4H+1kg/zDkW96qSrGoxsKEu7Qk7GZLXWElxnWR Y7uLg6J3562UnOGSHLHbTCiNJNeANecNKjuIx129PW1HwsAFSgpp0HnmLhtSS9cCsP SqMcYjPVX2cbIDrN5zWVHg1SOwoBWCX/yAUc/VLE= References: <87lej5x8ke.fsf@psyduck.jhoto.kublai.com> <87352opiw9.fsf_-_@gnu.org> User-agent: mu4e 1.10.2; emacs 29.0.91 Date: Tue, 20 Jun 2023 10:14:59 -0400 In-reply-to: <87352opiw9.fsf_-_@gnu.org> Message-ID: <87v8ficj1y.fsf@psyduck.jhoto.kublai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Brian Cully X-ACL-Warn: , Brian Cully via Guix-patches From: Brian Cully via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687270820; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GuRGoOLThWVCxY2I+m1km4MiQrAkKzK+nANRfYATnZw=; b=EL6V5V6T5TqfNOmbH3CEY+6DCosSUTP+JnSKPxb6vqcc1uxtpTw96u/F3Hjqv5XYZ3FGpw oJqMrViRJ0ctCm3wI6GPvAnaCpHKmImZMZMmCTJaOghZk0IykaCMyq2ctH9n81/xY6n9gK wm21HZhp/whWnLmAnl1rkVTfpk9GhbDrUR02bw98cQc86q2S5oYSaToPB2QzIaScEnEGjh m8ClZsaePQU9gH7+iLI4N2SQ1HrMbn7zafEJuYqQMWEDT+MR9n3VKwV7FL9tnU3OP3PC2z Oo8gVie2joAvdZf8CJb3/VawRwn2bazgvh9cUD9D7g8B6kAFzi1L5mCREdWJwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=cdY+PVX2; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687270820; a=rsa-sha256; cv=none; b=NmRjZ1z3+WvtF8z9C9YHMP2fMkUcks5mYngJnHG5SXiQksNKRKwH2AyjWnU8T2PD/exv3o BPuuV67ZsIlFVsKPwozpGe3h5CfBpeucI+5b43DZuE4bPrKvkhiLq114rQu9jHaKPhz/Hc CeQR69O+9zUhATKVF7fuiMhhC8tjwFFns0rqO9KQ+ZuPjVL2T4gbfoRgrGqozer+gtt6iW t4JMGDY+WScdqMDutClmyqGrfHIpY+dTgqxLQ+Fc3w1FaHNyV9B7e4fKDsMilGEvy/MW8E 8XFyyai8wE4HxzskOyaLi2fHu8t3SrH1WvYwDER62oIy/KP4d87Z93IMqrXz2Q== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.24 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=cdY+PVX2; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 826A63DF4E X-Spam-Score: -2.24 X-TUID: TRHfC/0RrNf3 Ludovic Court=C3=A8s writes: > Nitpick: for new files like =E2=80=98pam-mount.scm=E2=80=99 in this case,= it=E2=80=99s=20 > enough to > write =E2=80=9CNew file=E2=80=9D (relief :-)). Fixed. > Please add @* on the previous line to insert a line break. Fixed. FWIW, I tried looking through the manual (both Guix' and=20 TexInfo's) to see what this sigil meant, I couldn't figure it out,=20 so I just guessed. Is this documented somewhere? > Use the term =E2=80=9Cpair=E2=80=9D rather than =E2=80=9Ccons cell=E2=80= =9D (throughout the=20 > section), > for consistency with the rest of the manual and to make it more > approachable. Fixed. > How hard would it be to also have a system tests under (gnu=20 > tests =E2=80=A6)? > Seems like it would better cover functionality. I'm not sure. I've never done integration tests on an entire=20 operating system before, so it'd take some doing just to learn the=20 ropes. I'll go through the existing tests and see what I can come=20 up with. Would it be okay to do that as a separate patch, though? Given how=20 long I expect this work to take, I would like to avoid that extra=20 delay in having the current patch set (plus the above changes)=20 committed. -bjc