all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [FIXME] build: dub-build-system: Don't use "dub run" at all.
@ 2017-02-13 13:28 Danny Milosavljevic
  2017-02-13 14:33 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Danny Milosavljevic @ 2017-02-13 13:28 UTC (permalink / raw)
  To: guix-devel

* guix/build/dub-build-system.scm (build): Modify.
---
 guix/build/dub-build-system.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/guix/build/dub-build-system.scm b/guix/build/dub-build-system.scm
index 7c7cd8803..b2cb02e63 100644
--- a/guix/build/dub-build-system.scm
+++ b/guix/build/dub-build-system.scm
@@ -91,9 +91,7 @@
           (grep* "sourceLibrary" "dub.sdl") ; note: format is different!
           (grep* "sourceLibrary" "dub.json"))
     #t
-    (let ((status (zero? (apply system* `("dub" "build" ,@dub-build-flags)))))
-      (system* "dub" "run") ; might fail for "targetType": "library"
-      status)))
+    (zero? (apply system* `("dub" "build" ,@dub-build-flags)))))
 
 (define* (check #:key tests? #:allow-other-keys)
   (if tests?

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [FIXME] build: dub-build-system: Don't use "dub run" at all.
  2017-02-13 13:28 [FIXME] build: dub-build-system: Don't use "dub run" at all Danny Milosavljevic
@ 2017-02-13 14:33 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2017-02-13 14:33 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: guix-devel

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * guix/build/dub-build-system.scm (build): Modify.

Please describe the actual modification, like “Remove "dub run"
invocation.”

Also, please explain the change somewhere: either as a comment in the
code, if you think someone might wonder why we’re not invoking “dub run”
here (like “It’s tempting to invoke "dub run" here but we don’t do that
because of this and that.”), or in the commit log if it was just a
mistake.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-13 14:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-13 13:28 [FIXME] build: dub-build-system: Don't use "dub run" at all Danny Milosavljevic
2017-02-13 14:33 ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.