From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: Alex Kost <alezost@gmail.com>, help-guix@gnu.org
Subject: Re: Guix upgrade leads to different hashes
Date: Sat, 07 Oct 2017 17:10:14 +0200 [thread overview]
Message-ID: <87tvzbj8o9.fsf@gnu.org> (raw)
In-Reply-To: <87fuav1k78.fsf@gmail.com> (Oleg Pykhalov's message of "Sat, 07 Oct 2017 10:38:35 +0300")
Hi,
Oleg Pykhalov <go.wigust@gmail.com> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>>
>>> ludo@gnu.org (Ludovic Courtès) writes:
>>>
>>> [...]
>>>
>>>> Could you check if this patch helps:
>>>>
>>>> diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
>>>> index 4adc70522..0e365018a 100644
>>>> --- a/guix/scripts/package.scm
>>>> +++ b/guix/scripts/package.scm
>>>> @@ -604,12 +604,12 @@ and upgrades."
>>>> (options->upgrade-predicate opts))
>>>>
>>>> (define upgraded
>>>> - (fold (lambda (entry transaction)
>>>> - (if (upgrade? (manifest-entry-name entry))
>>>> - (transaction-upgrade-entry entry transaction)
>>>> - transaction))
>>>> - transaction
>>>> - (manifest-entries manifest)))
>>>> + (fold-right (lambda (entry transaction)
>>>> + (if (upgrade? (manifest-entry-name entry))
>>>> + (transaction-upgrade-entry entry transaction)
>>>> + transaction))
>>>> + transaction
>>>> + (manifest-entries manifest)))
>>>>
>>>> (define to-install
>>>> (filter-map (match-lambda
[...]
> I'm sorry, actually after patching no new generation created. But
> dry-run still shows available upgrades and that will be build some
> derivations.
>
> $ guix package -p /home/natsu/.my-guix-profile/debug-upgrade -m /home/natsu/dotfiles/guix/user.scm
I’ve pushed the above patch as eca16a3d1d9e6b2c064e0105c1015258bf2755f2.
Now we need to fix the UI side of things.
Could you resend the info to bug-guix@gnu.org so we keep track of it?
Thanks!
Ludo’.
next prev parent reply other threads:[~2017-10-07 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 2:15 Guix upgrade leads to different hashes Oleg Pykhalov
2017-10-02 19:35 ` Alex Kost
2017-10-03 9:40 ` Oleg Pykhalov
2017-10-03 19:56 ` Ludovic Courtès
2017-10-03 21:44 ` Oleg Pykhalov
2017-10-04 8:28 ` Ludovic Courtès
2017-10-05 0:10 ` Oleg Pykhalov
2017-10-05 13:08 ` Ludovic Courtès
2017-10-06 16:36 ` Oleg Pykhalov
2017-10-06 22:24 ` Ludovic Courtès
2017-10-07 7:38 ` Oleg Pykhalov
2017-10-07 15:10 ` Ludovic Courtès [this message]
2017-10-08 7:06 ` bug#28743: guix package dry-run upgrade shows not required derivations (UI issue) Oleg Pykhalov
2021-09-16 7:18 ` bug#28743: guix package dry-run upgrade incorrect behaviour with verbosity zimoun
2022-01-04 23:06 ` bug#28743: guix package dry-run upgrade shows not required derivations (UI issue) zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvzbj8o9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=go.wigust@gmail.com \
--cc=help-guix@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.