From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27791@debbugs.gnu.org
Subject: [bug#27791] [PATCH] gnu: Add passmenu
Date: Mon, 16 Oct 2017 15:22:47 +0200 [thread overview]
Message-ID: <87tvyzcjmg.fsf@gnu.org> (raw)
In-Reply-To: <87zibw4oen.fsf@fastmail.com> (Marius Bakke's message of "Sat, 22 Jul 2017 15:00:32 +0200")
Hi Jelle,
Is anything holding this back?
https://bugs.gnu.org/27791
TIA! :-)
Ludo’.
Marius Bakke <mbakke@fastmail.com> skribis:
> Hi Jelle,
>
> Jelle Licht <jlicht@fsfe.org> writes:
>
>> Hello guix,
>>
>> Attached is a patch to include passmenu, a dmenu interface to the pass
>> password store.
>>
>> I was not quite sure how to structure this patch, as it basically installs
>> and wraps a shell script from the `password-store' sources. We could
>> instead include it as a separate output of our `password-store' package,
>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even
>> sure if that approach was in general preferable.
>
> I don't think wrapping it with dmenu in PATH is necessary. Users of this
> script are expected to have dmenu from before, and may want to use
> another implementation (e.g. rofi), another version, etc.
>
> Can you try to simply add a phase to the normal password-store package
> that copies this file to out/bin? We can probably avoid the wrapper too
> by giving it the full path to `xdotool`, e.g.:
>
> (substitute "passmenu"
> (("xdotool") (string-append (assoc-ref inputs "xdotool")
> "/bin/xdotool")))
>
> Adding 'xdotool' adds ~8MiB to the password-store closure size, so I
> don't think we need a separate output either.
>
> Thanks!
next prev parent reply other threads:[~2017-10-16 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 12:35 [bug#27791] [PATCH] gnu: Add passmenu Jelle Licht
2017-07-22 13:00 ` Marius Bakke
2017-10-16 13:22 ` Ludovic Courtès [this message]
2017-10-16 14:05 ` Jelle Licht
2017-10-16 22:09 ` Marius Bakke
2017-11-10 13:50 ` bug#27791: " Jelle Licht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvyzcjmg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27791@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.