From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58293)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e45MI-0002fi-SR
	for guix-patches@gnu.org; Mon, 16 Oct 2017 09:23:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e45MD-0007bI-Tl
	for guix-patches@gnu.org; Mon, 16 Oct 2017 09:23:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33973)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e45MD-0007bE-Pr
	for guix-patches@gnu.org; Mon, 16 Oct 2017 09:23:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e45MD-0005Fu-JE
	for guix-patches@gnu.org; Mon, 16 Oct 2017 09:23:01 -0400
Subject: [bug#27791] [PATCH] gnu: Add passmenu
Resent-Message-ID: <handler.27791.B27791.150816017320182@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <CAPsKtfKfXFQUpZHPy_iv3Fq5oVtrty4+RRi2+mfYsk9MchrJUw@mail.gmail.com>
	<87zibw4oen.fsf@fastmail.com>
Date: Mon, 16 Oct 2017 15:22:47 +0200
In-Reply-To: <87zibw4oen.fsf@fastmail.com> (Marius Bakke's message of "Sat, 22
	Jul 2017 15:00:32 +0200")
Message-ID: <87tvyzcjmg.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27791@debbugs.gnu.org

Hi Jelle,

Is anything holding this back?

  https://bugs.gnu.org/27791

TIA!  :-)

Ludo=E2=80=99.

Marius Bakke <mbakke@fastmail.com> skribis:

> Hi Jelle,
>
> Jelle Licht <jlicht@fsfe.org> writes:
>
>> Hello guix,
>>
>> Attached is a patch to include passmenu, a dmenu interface to the pass
>> password store.
>>
>> I was not quite sure how to structure this patch, as it basically instal=
ls
>> and wraps a shell script from the `password-store' sources. We could
>> instead include it as a separate output of our `password-store' package,
>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even
>> sure if that approach was in general preferable.
>
> I don't think wrapping it with dmenu in PATH is necessary. Users of this
> script are expected to have dmenu from before, and may want to use
> another implementation (e.g. rofi), another version, etc.
>
> Can you try to simply add a phase to the normal password-store package
> that copies this file to out/bin? We can probably avoid the wrapper too
> by giving it the full path to `xdotool`, e.g.:
>
> (substitute "passmenu"
>   (("xdotool") (string-append (assoc-ref inputs "xdotool")
>                               "/bin/xdotool")))
>
> Adding 'xdotool' adds ~8MiB to the password-store closure size, so I
> don't think we need a separate output either.
>
> Thanks!