From: iyzsong@member.fsf.org (宋文武)
To: Christopher Baines <mail@cbaines.net>
Cc: 31678@debbugs.gnu.org
Subject: [bug#31678] [PATCH 2/2] gnu: elixir: Enable more tests and remove patch.
Date: Sun, 10 Jun 2018 12:51:22 +0800 [thread overview]
Message-ID: <87tvqbgs6t.fsf@member.fsf.org> (raw)
In-Reply-To: <20180601135106.32680-2-mail@cbaines.net> (Christopher Baines's message of "Fri, 1 Jun 2018 14:51:06 +0100")
Christopher Baines <mail@cbaines.net> writes:
> Previously, due to issues in the erlang package, many tests would fail, and
> the package would also nondeterministically fail to build. This is now
> fixed (by patching occurances of /bin/sh in the erlang package), so all the
> tests can be run.
>
> * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is no
> longer necessary, as all the tests now pass.
> [arguments]: Remove the fix-or-disable-tests phase, all the tests now
> pass. Add a new set-home phase to set the HOME environment variable prior to
> running the tests, as that was previously done at the start of the
> fix-or-disable-tests phase.
> * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this file,
> as it is now unused.
I think generally we only need to mention the ‘what’ parts, not the
‘why’ parts (“as …”) in the per-file details, but I guess it’s nothing
wrong to do it :-)
> * gnu/local.mk: Remove now deleted patch.
* gnu/local.mk (GNU_SYSTEM_MODULES): ...
> ---
> gnu/local.mk | 1 -
> gnu/packages/elixir.scm | 36 +--
> .../elixir-disable-failing-tests.patch | 284 ------------------
> 3 files changed, 6 insertions(+), 315 deletions(-)
Cool, thank you!
next prev parent reply other threads:[~2018-06-10 4:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 13:46 [bug#31678] [PATCH 0/2] Elixir and Erlang improvements Christopher Baines
2018-06-01 13:51 ` [bug#31678] [PATCH 1/2] gnu: erlang: Patch occurrences of /bin/sh in the source Christopher Baines
2018-06-01 13:51 ` [bug#31678] [PATCH 2/2] gnu: elixir: Enable more tests and remove patch Christopher Baines
2018-06-10 4:51 ` 宋文武 [this message]
2018-06-12 6:55 ` bug#31678: " Christopher Baines
2018-06-10 4:41 ` [bug#31678] [PATCH 1/2] gnu: erlang: Patch occurrences of /bin/sh in the source 宋文武
2018-06-10 6:00 ` 宋文武
2018-06-12 6:56 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvqbgs6t.fsf@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=31678@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.