From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRsKj-00061K-DY for guix-patches@gnu.org; Sun, 10 Jun 2018 00:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRsKg-0006KQ-BY for guix-patches@gnu.org; Sun, 10 Jun 2018 00:52:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRsKg-0006KF-7B for guix-patches@gnu.org; Sun, 10 Jun 2018 00:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRsKf-0004NI-Qq for guix-patches@gnu.org; Sun, 10 Jun 2018 00:52:01 -0400 Subject: [bug#31678] [PATCH 2/2] gnu: elixir: Enable more tests and remove patch. Resent-Message-ID: From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) References: <20180601135106.32680-1-mail@cbaines.net> <20180601135106.32680-2-mail@cbaines.net> Date: Sun, 10 Jun 2018 12:51:22 +0800 In-Reply-To: <20180601135106.32680-2-mail@cbaines.net> (Christopher Baines's message of "Fri, 1 Jun 2018 14:51:06 +0100") Message-ID: <87tvqbgs6t.fsf@member.fsf.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 31678@debbugs.gnu.org Christopher Baines writes: > Previously, due to issues in the erlang package, many tests would fail, a= nd > the package would also nondeterministically fail to build. This is now > fixed (by patching occurances of /bin/sh in the erlang package), so all t= he > tests can be run. > > * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is = no > longer necessary, as all the tests now pass. > [arguments]: Remove the fix-or-disable-tests phase, all the tests now > pass. Add a new set-home phase to set the HOME environment variable prior= to > running the tests, as that was previously done at the start of the > fix-or-disable-tests phase. > * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this fi= le, > as it is now unused. I think generally we only need to mention the =E2=80=98what=E2=80=99 parts,= not the =E2=80=98why=E2=80=99 parts (=E2=80=9Cas =E2=80=A6=E2=80=9D) in the per-fil= e details, but I guess it=E2=80=99s nothing wrong to do it :-) > * gnu/local.mk: Remove now deleted patch. * gnu/local.mk (GNU_SYSTEM_MODULES): ... > --- > gnu/local.mk | 1 - > gnu/packages/elixir.scm | 36 +-- > .../elixir-disable-failing-tests.patch | 284 ------------------ > 3 files changed, 6 insertions(+), 315 deletions(-) Cool, thank you!