From: Christopher Baines <mail@cbaines.net>
To: John Soo <jsoo1@asu.edu>
Cc: 38596-done@debbugs.gnu.org
Subject: bug#38596: [PATCH] gnu: Add PureScript.
Date: Fri, 08 May 2020 10:13:25 +0100 [thread overview]
Message-ID: <87tv0qg56y.fsf@cbaines.net> (raw)
In-Reply-To: <87sggb2rn1.fsf@asu.edu>
[-- Attachment #1: Type: text/plain, Size: 2461 bytes --]
John Soo <jsoo1@asu.edu> writes:
> Christopher Baines <mail@cbaines.net> writes:
>
>> Some really minor description things I missed earlier:
>>
>> ghc-aeson-better-errors, ghc-transformers and ghc-websockets have URLs
>> in the description, @url could probably be used.
>>
>> I'd also remove the following from the ghc-bower-json description, it
>> reads more like uninformative advertising to me and isn't really
>> relevant to this specific package:
>>
>> Bower is a package manager for the web (see http://bower.io).
>
> Done!
>
>> Maybe it would be good to note why the package in Guix didn't work, like
>> I tried to use ghc-happy@1.19.12, and the build phase failed with some
>> type errors. That'll at least point out clearly that there's an
>> incompatability. I don't think much detail is needed, the following
>> would be fine.
>>
>> `(("ghc-happy" ,ghc-happy-1.19.9) ; build fails with 1.19.12
>
> Done!
>
>>> Ah thanks for the suggestion here. I found one that could be taken from
>>> the existing package in (gnu packages haskell-xyz). The rest seemed to
>>> be either pinned exactly or too strict to take from guix packages.
>>
>> Thanks, although my intent was more about adding something like this.
>>
>> #:phases
>> (modify-phases %standard-phases
>> (add-after 'unpack 'patch
>> (lambda _
>> (substitute* "purescript.cabal"
>> (("clock .*$")
>> "clock,\n"))
>> #t)))))
>
> With the addition of a patch I was able to relax most of the package
> versions I introduced to ones we have. The final remaining required
> dependency seems to be happy which I kept at 1.19.9.
Awesome. I added the patch to the list in gnu/local.mk, which I think is
necessary when building the guix package for guix at least. I also added
a small comment to the top of the patch.
>> Now I'm not sure quite how risky this is, the purescript tests aren't
>> being run, but given this is Haskell and it compiles, hopefully that
>> provides some guarantees.
>>
>> What do you think?
>
> My only caveat too is now I have not really tested this version. I had
> done some work with a prior version. I wish I could run the tests but
> they seem to rely heavily on npm and bower.
Personally, I think that's fine for the moment. It builds at least and I
can run purs to at least get the help.
I've gone ahead and pushed these patches as
de488b3a5fff4535471f6706da03e1b74e6a37fd, thanks for all your work!
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
prev parent reply other threads:[~2020-05-08 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 18:46 [bug#38596] [PATCH] Add PureScript John Soo
2019-12-18 13:50 ` John Soo
2019-12-18 14:30 ` John Soo
2020-04-11 20:12 ` [bug#38596] [PATCH] gnu: " John Soo
2020-04-17 19:21 ` Christopher Baines
2020-04-18 22:31 ` John Soo
2020-04-21 7:55 ` Christopher Baines
2020-05-08 0:32 ` John Soo
2020-05-08 9:13 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv0qg56y.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=38596-done@debbugs.gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.