From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yGmgCtgitV7fSQAA0tVLHw (envelope-from ) for ; Fri, 08 May 2020 09:14:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wGGkKuQitV4WfQAAB5/wlQ (envelope-from ) for ; Fri, 08 May 2020 09:14:12 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 79907941100 for ; Fri, 8 May 2020 09:14:10 +0000 (UTC) Received: from localhost ([::1]:42392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWz59-0003QG-54 for larch@yhetil.org; Fri, 08 May 2020 05:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWz50-0003Ns-NN for guix-patches@gnu.org; Fri, 08 May 2020 05:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWz50-0003I6-ED for guix-patches@gnu.org; Fri, 08 May 2020 05:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWz50-0001Ke-34 for guix-patches@gnu.org; Fri, 08 May 2020 05:14:02 -0400 Subject: bug#38596: [PATCH] gnu: Add PureScript. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 08 May 2020 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 38596 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: John Soo Cc: 38596-done@debbugs.gnu.org Mail-Followup-To: 38596@debbugs.gnu.org, mail@cbaines.net, jsoo1@asu.edu Received: via spool by 38596-done@debbugs.gnu.org id=D38596.15889292135071 (code D ref 38596); Fri, 08 May 2020 09:14:01 +0000 Received: (at 38596-done) by debbugs.gnu.org; 8 May 2020 09:13:33 +0000 Received: from localhost ([127.0.0.1]:44596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWz4X-0001Ji-DE for submit@debbugs.gnu.org; Fri, 08 May 2020 05:13:33 -0400 Received: from mira.cbaines.net ([212.71.252.8]:40898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWz4V-0001Ja-4w for 38596-done@debbugs.gnu.org; Fri, 08 May 2020 05:13:31 -0400 Received: from localhost (unknown [46.237.174.28]) by mira.cbaines.net (Postfix) with ESMTPSA id 3069F27BBE1; Fri, 8 May 2020 10:13:30 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 3a51dc17; Fri, 8 May 2020 09:13:27 +0000 (UTC) References: <87k12lrdd3.fsf@asu.edu> <87imhx6hpl.fsf@cbaines.net> <87k12cifxs.fsf@asu.edu> <87o8rl46iu.fsf@cbaines.net> <87sggb2rn1.fsf@asu.edu> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines In-reply-to: <87sggb2rn1.fsf@asu.edu> Date: Fri, 08 May 2020 10:13:25 +0100 Message-ID: <87tv0qg56y.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-3.11 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49893519798558]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.10), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mail@cbaines.net,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[bower.io:url,asu.edu:email,cbaines.net:email,1.19.0.12:email]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DMARC_NA(0.00)[cbaines.net]; HAS_LIST_UNSUB(-0.01)[]; DBL_PROHIBIT(0.00)[1.19.0.12:email]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: 9xkKXNQQ8274 --=-=-= Content-Type: text/plain John Soo writes: > Christopher Baines writes: > >> Some really minor description things I missed earlier: >> >> ghc-aeson-better-errors, ghc-transformers and ghc-websockets have URLs >> in the description, @url could probably be used. >> >> I'd also remove the following from the ghc-bower-json description, it >> reads more like uninformative advertising to me and isn't really >> relevant to this specific package: >> >> Bower is a package manager for the web (see http://bower.io). > > Done! > >> Maybe it would be good to note why the package in Guix didn't work, like >> I tried to use ghc-happy@1.19.12, and the build phase failed with some >> type errors. That'll at least point out clearly that there's an >> incompatability. I don't think much detail is needed, the following >> would be fine. >> >> `(("ghc-happy" ,ghc-happy-1.19.9) ; build fails with 1.19.12 > > Done! > >>> Ah thanks for the suggestion here. I found one that could be taken from >>> the existing package in (gnu packages haskell-xyz). The rest seemed to >>> be either pinned exactly or too strict to take from guix packages. >> >> Thanks, although my intent was more about adding something like this. >> >> #:phases >> (modify-phases %standard-phases >> (add-after 'unpack 'patch >> (lambda _ >> (substitute* "purescript.cabal" >> (("clock .*$") >> "clock,\n")) >> #t))))) > > With the addition of a patch I was able to relax most of the package > versions I introduced to ones we have. The final remaining required > dependency seems to be happy which I kept at 1.19.9. Awesome. I added the patch to the list in gnu/local.mk, which I think is necessary when building the guix package for guix at least. I also added a small comment to the top of the patch. >> Now I'm not sure quite how risky this is, the purescript tests aren't >> being run, but given this is Haskell and it compiles, hopefully that >> provides some guarantees. >> >> What do you think? > > My only caveat too is now I have not really tested this version. I had > done some work with a prior version. I wish I could run the tests but > they seem to rely heavily on npm and bower. Personally, I think that's fine for the moment. It builds at least and I can run purs to at least get the help. I've gone ahead and pushed these patches as de488b3a5fff4535471f6706da03e1b74e6a37fd, thanks for all your work! Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl61IrVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeGwQ/9FjkxeXg4A35acSNgTK7AEEzH18JaHf06SgVR0Mw04XP0pw4YpvRQQ22r x6c00ZBbEL8/Jt+nhInVQuzYsY+VCLEDY1wVI9BxYuKmv1OoM/gzVofKb7sR+c9j MgECy03cKQCM1Go1iNbzHESHSgnlMfYapekxBA6oc42/PngoWw6Hi9Kkb1FniUeU Gb0M3dkBeRuVKwCW36SaskYDryBzC1XYH2I9HJrG8nc2VSek0CxM4XS2vSYL7vRl AEMqAizJm1Nb0z6VagvlO5KxvD3hl2hPjP5vn7G1vvPv1HjDCBjtgbPEV6MnWxTX uTrMzMQlTDtoFZsGIQLqPq/htlocBXhz8+skRpDlYwF5blC0icjTe0o4LywcrPA7 kKzsmYPjDCxTXWHxmmUEWruVPMslVx6Qh5z3tvxIw/eWtNxSmYR9ejBUVp+K633Z zgbycDgBGaStwxZvwZfCwwiYnr8GXDj89K1ApyBTX2SfLbWViPrDSURz40XMBAL/ 2jZWT3xJ5gY/Y8/W+SghIiZa5K2fkH+BlDv4ouYS3gFELD4/nsruCIPkkK6cUP9h Ra5xxaoO6/2tfYFPDkbdTbuzb9nCh5xK68xizR2guGujQEpk5PgLV8f73NiA8Bc+ gAxvbtNwdl6ROTUpKD/U9ZKm4UnEOM8VBOj9uhlN9jpVgrhsfY8= =bNTc -----END PGP SIGNATURE----- --=-=-=--