all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 48984@debbugs.gnu.org
Subject: [bug#48984] [PATCH] gnu: ddcutil: Patch kernel modules paths.
Date: Sun, 13 Jun 2021 12:35:30 +0200	[thread overview]
Message-ID: <87tum2xdal.fsf@nckx> (raw)
In-Reply-To: <20210612212422.13271-1-brice@waegenei.re>

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Brice,

Thanks for the patch!  Does it affect more than ‘ddcutil 
detect/environment’?  Anything ‘real’?

Working around one of many bugs in a broken diagnostic subtool 
isn't worth maintaining a 32-line patch.

Brice Waegeneire 写道:
> Without it "ddcutil detect" complain: “Module i2c-dev is not 
> loaded and
> ddcutil can't determine if it is built into the kernel”.

With it, it still complains:

  ~ λ ddcutil detect
  Module i2c-dev is not loaded and not built into the kernel.
  ddcutil requires module i2c-dev

It doesn't address the built-in case either, AFAICS.

The very idea of ddcutil's linux_util.c is flawed and can't be 
fixed: you don't look in /etc for the running kernel version; you 
don't use that ill-gotten string to start scanning random system 
directories for .ko files; you don't check for built-in modules by 
looking for possibly installed build leftovers.  None of that 
makes sense.  You ask kmod.  You ask the kernel!

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2021-06-13 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12 21:24 [bug#48984] [PATCH] gnu: ddcutil: Patch kernel modules paths Brice Waegeneire
2021-06-13 10:35 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2021-06-13 13:07   ` Brice Waegeneire
2022-01-21 23:21 ` bug#48984: " Brice Waegeneire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tum2xdal.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=48984@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.