From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0EWCNVvfxWD/mAAAgWs5BA (envelope-from ) for ; Sun, 13 Jun 2021 12:35:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cAw+MVvfxWCCWQAAB5/wlQ (envelope-from ) for ; Sun, 13 Jun 2021 10:35:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44CD1152DD for ; Sun, 13 Jun 2021 12:35:07 +0200 (CEST) Received: from localhost ([::1]:59416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsNSM-0000M3-99 for larch@yhetil.org; Sun, 13 Jun 2021 06:35:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsNSI-0000Ls-Jt for guix-patches@gnu.org; Sun, 13 Jun 2021 06:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsNSI-00067z-Ca for guix-patches@gnu.org; Sun, 13 Jun 2021 06:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lsNSI-0006nt-7g for guix-patches@gnu.org; Sun, 13 Jun 2021 06:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48984] [PATCH] gnu: ddcutil: Patch kernel modules paths. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Jun 2021 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48984 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 48984@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 48984@debbugs.gnu.org Received: via spool by 48984-submit@debbugs.gnu.org id=B48984.162358049826133 (code B ref 48984); Sun, 13 Jun 2021 10:35:02 +0000 Received: (at 48984) by debbugs.gnu.org; 13 Jun 2021 10:34:58 +0000 Received: from localhost ([127.0.0.1]:42716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsNSD-0006nR-Sv for submit@debbugs.gnu.org; Sun, 13 Jun 2021 06:34:58 -0400 Received: from tobias.gr ([80.241.217.52]:44310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsNSC-0006nH-7p for 48984@debbugs.gnu.org; Sun, 13 Jun 2021 06:34:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=YIaDrlaZlz35XFkBUStjc02d4BjLaYzQmjbX5Iu3xv8=; h=date:in-reply-to: subject:cc:to:from:references; b=PqsrSBFhpWn5dFZtCqcn5NcXCTYTw80aw0+53 U26qvUot4S/edJLpO2x4yoge6KZ6ToYvaIfYfDde1IsQMF5GrQS9pUINHsmTGgijgPBGKG QnE2loZJZV9qfQ/p3xY1jaQsGQj57rhTY7q5AXV3utRNg9d5QPYjRwG4tqduM5ZZHTXeuG HlEDEN5HGbWTBwSXhosliL/N8X+srSfrH1t5pR6n3hB6i1E+bK82LoLIHL3pYnp0iy4WP0 H9SPruYVM77z/FIc9c+VcNwWZVEeYyb5UN2CjOEy8zKql1Xp2cf0PF9NH5lWtOZycg0pTJ DLIrUkp+zXYbWwvxNE1IBzB5w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 006858e6 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Sun, 13 Jun 2021 10:34:52 +0000 (UTC) References: <20210612212422.13271-1-brice@waegenei.re> In-reply-to: <20210612212422.13271-1-brice@waegenei.re> BIMI-Selector: v=BIMI1; s=default; Date: Sun, 13 Jun 2021 12:35:30 +0200 Message-ID: <87tum2xdal.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623580507; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=YIaDrlaZlz35XFkBUStjc02d4BjLaYzQmjbX5Iu3xv8=; b=ldBFVYftqIymjRyk0BCrezIJoZZn16WnAW2mLMJcV2OWeFQJNBKzOr06unDAXQ6+0NFZox Ql+M/3zn/TKqs0/KEZufS/3X22Cy9b5EPmxp1Y4S2OfJXvc7Uq/WfGL25mqj8YtvCsC9Xo 1cWO066++rAvr0HgIIMe14MKCiX2w3Tp1yF3ILo0BMvvrQiVpndUSyjx4ewfNM4Rjsie1A 0qVZpZDQ1RgP+r3jPDXjsZHXkkQX51ZVVB1q6ceac5LtkA89jjjiflVrAmi5BHbToBVz3i FxtfUfPWZSIoFwnG+I6uUfu3Tx9ky7ApvSeMgD2Va5J6H1ACb4JW3XM9cw1J+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623580507; a=rsa-sha256; cv=none; b=M32Eft1/F+ys56+cAdfHrFOIt3efMjqDuCZ0b6OFxaVSBOlk3w7IqVxsy3UeM1HCFxqc1P BV9VCuz//XoIFyiq0WYILLnZ9u1hz8x3E2r8C8JDVkBYOJI72dz79A7O0vsirUOxf2moyx r9x6YaAHZnZejD6abf6aoYSYe+m2I9BnSJE2ihemiCb3/coWG7yO7Jnyk5yNx4rOq4O+BH AU0ZUMOhp67wjjMbHtq3x0WeB6fPEMIalNgasoYMahEA9V5ySQiFW3ivMP2EnsTytLmDX1 z5l0/+4JZ7zeanmkmYLPJmLDYOFs69m/lXNfVzwWxmbgmkIe8kUZUAsOA3rOpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=PqsrSBFh; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=PqsrSBFh; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 44CD1152DD X-Spam-Score: -4.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: lk5hxcSxilM4 --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Brice, Thanks for the patch! Does it affect more than =E2=80=98ddcutil=20 detect/environment=E2=80=99? Anything =E2=80=98real=E2=80=99? Working around one of many bugs in a broken diagnostic subtool=20 isn't worth maintaining a 32-line patch. Brice Waegeneire =E5=86=99=E9=81=93=EF=BC=9A > Without it "ddcutil detect" complain: =E2=80=9CModule i2c-dev is not=20 > loaded and > ddcutil can't determine if it is built into the kernel=E2=80=9D. With it, it still complains: ~ =CE=BB ddcutil detect Module i2c-dev is not loaded and not built into the kernel. ddcutil requires module i2c-dev It doesn't address the built-in case either, AFAICS. The very idea of ddcutil's linux_util.c is flawed and can't be=20 fixed: you don't look in /etc for the running kernel version; you=20 don't use that ill-gotten string to start scanning random system=20 directories for .ko files; you don't check for built-in modules by=20 looking for possibly installed build leftovers. None of that=20 makes sense. You ask kmod. You ask the kernel! Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYMXfcg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW154yUA+gIzNLf8OQaN0K4cDWZG4lKvGh08oUm8NzhPuSoS Zp9XAP9ofj60PgwubFgHss4bcQnA0UYxEVIIUxs2BswdLh7rBg== =mmOo -----END PGP SIGNATURE----- --=-=-=--