From: "Ludovic Courtès" <ludo@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 49056@debbugs.gnu.org
Subject: [bug#49056] [PATCH] services: pcscd: Fix daemon signal handling.
Date: Sat, 26 Jun 2021 22:59:53 +0200 [thread overview]
Message-ID: <87tulk1gvq.fsf@gnu.org> (raw)
In-Reply-To: <20210616063818.12656-1-brice@waegenei.re> (Brice Waegeneire's message of "Wed, 16 Jun 2021 08:38:18 +0200")
Hi,
Brice Waegeneire <brice@waegenei.re> skribis:
> "pcscd" wouldn't handle SIGTERM as it inherited ignoring this
> signal (and others) from its parent shepherd. The constructor
> make-forkexec, restore signal handling. Fixes
> <https://issues.guix.gnu.org/45202>.
>
> * gnu/services/security-token.scm (pcscd)[start]: Use
> make-fork-exec-constructor to start "pcscd".
Well done!
> + (start #~(lambda args
> (let ((socket "/run/pcscd/pcscd.comm"))
> (when (file-exists? socket)
> (delete-file socket)))
> - (invoke #$(file-append pcsc-lite "/sbin/pcscd"))
> - (call-with-input-file "/run/pcscd/pcscd.pid" read)))
> + (apply (make-forkexec-constructor
> + (list #$(file-append pcsc-lite "/sbin/pcscd")
> + "--foreground")
> + #:log-file "/var/log/pcscd.log")
> + args)))
We can probably call ‘fork+exec-command’ directly instead of going
through ‘make-forkexec-constructor’, no?
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2021-06-26 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 6:38 [bug#49056] [PATCH] services: pcscd: Fix daemon signal handling Brice Waegeneire
2021-06-26 20:59 ` Ludovic Courtès [this message]
2021-07-03 18:18 ` bug#49056: " Brice Waegeneire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tulk1gvq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=49056@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.