From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sn9jK52V12AJtQAAgWs5BA (envelope-from ) for ; Sat, 26 Jun 2021 23:01:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IHKNJp2V12DRSAAA1q6Kng (envelope-from ) for ; Sat, 26 Jun 2021 21:01:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C7D113F98 for ; Sat, 26 Jun 2021 23:01:17 +0200 (CEST) Received: from localhost ([::1]:34254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxFQS-0006pv-0W for larch@yhetil.org; Sat, 26 Jun 2021 17:01:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxFQF-0006pn-99 for guix-patches@gnu.org; Sat, 26 Jun 2021 17:01:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxFQE-00016m-3T for guix-patches@gnu.org; Sat, 26 Jun 2021 17:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lxFQD-0004HP-Vd for guix-patches@gnu.org; Sat, 26 Jun 2021 17:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49056] [PATCH] services: pcscd: Fix daemon signal handling. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Jun 2021 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49056 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 49056@debbugs.gnu.org Received: via spool by 49056-submit@debbugs.gnu.org id=B49056.162474120616295 (code B ref 49056); Sat, 26 Jun 2021 21:01:01 +0000 Received: (at 49056) by debbugs.gnu.org; 26 Jun 2021 21:00:06 +0000 Received: from localhost ([127.0.0.1]:48715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxFPK-0004Ek-AN for submit@debbugs.gnu.org; Sat, 26 Jun 2021 17:00:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxFPH-0004Df-1t for 49056@debbugs.gnu.org; Sat, 26 Jun 2021 17:00:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40870) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxFPB-0000Mj-5C; Sat, 26 Jun 2021 16:59:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42488 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxFP9-0003c8-Md; Sat, 26 Jun 2021 16:59:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210616063818.12656-1-brice@waegenei.re> Date: Sat, 26 Jun 2021 22:59:53 +0200 In-Reply-To: <20210616063818.12656-1-brice@waegenei.re> (Brice Waegeneire's message of "Wed, 16 Jun 2021 08:38:18 +0200") Message-ID: <87tulk1gvq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624741277; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=IUR+f9pQJgBjKC3DWFsBIXsD04xl+P0Ptbx2u8ULKMk=; b=eC64KiCvUpZhgwns3Ahj+mCHY6QA9ROIfzpQPiPS8DrJjeuS1a56C7FYI6oqifSEtj8p6H tb0rSt1A9xb8Ol2Nnjak2pVHPRDaDsK4K+PPDSmvkvG+CVuuvzwtaAIHaRCs3AY+6di+zV MWYu4EwhlwuYDc1YhOhv1IFpcMDnzfZwiECHuLwLvuZzwSF5yo8urdsG2kCnTdZcPf78R6 +quyx4njJJ7S6nBsyaIBdXG74r9a5ZKdhQO6ECHrIxwXjpy6wkTA6Yg21AZB4akeL50evP SjwkdaK8+vZUoTr7gYxU7Mvp3ak2qqlPUIA6YvHEcfIO6y5kUztbg9xLCZp1VA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624741277; a=rsa-sha256; cv=none; b=hvi90Xlwzbd2pi8ZXitebqNvbjVeHjCp9mlpa1ZpIKrW8k2qFrL3sELJQ+M76xSKnLNtMR WfTd82RQVwEgqcn6T4Ke3hB/Xi/fdKrfXmi65tM8eNx7GmdrvpjD+G6JARgdgJ3+KegWnC /0lMg6JID8UXD4HMYbmjawkSwUiP4ygV10LaRgdRLP9zZyITbi2xwgOx1dzJ1Q16HcLpGY V8WTLs3uCJHmdOuCSwsjOuCUq1s4CERHcsnjn/h4ZBKlqBgOvm2FbkP5EJTjdGdZeB05pn 29JoYfV6LZayH+mfww6wBPHT5ZkJssKJju8QouypwWa68R0tXzsM21rfABW8og== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5C7D113F98 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: cT1SuDReE8Wx Hi, Brice Waegeneire skribis: > "pcscd" wouldn't handle SIGTERM as it inherited ignoring this > signal (and others) from its parent shepherd. The constructor > make-forkexec, restore signal handling. Fixes > . > > * gnu/services/security-token.scm (pcscd)[start]: Use > make-fork-exec-constructor to start "pcscd". Well done! > + (start #~(lambda args > (let ((socket "/run/pcscd/pcscd.comm")) > (when (file-exists? socket) > (delete-file socket))) > - (invoke #$(file-append pcsc-lite "/sbin/pcscd")) > - (call-with-input-file "/run/pcscd/pcscd.pid" read))) > + (apply (make-forkexec-constructor > + (list #$(file-append pcsc-lite "/sbin/pcscd") > + "--foreground") > + #:log-file "/var/log/pcscd.log") > + args))) We can probably call =E2=80=98fork+exec-command=E2=80=99 directly instead o= f going through =E2=80=98make-forkexec-constructor=E2=80=99, no? Otherwise LGTM, thanks! Ludo=E2=80=99.