From: "Ludovic Courtès" <ludo@gnu.org>
To: Jaft <jaft.r@outlook.com>
Cc: 52030@debbugs.gnu.org
Subject: [bug#52030] [PATCH] gnu: Add feather font
Date: Fri, 10 Dec 2021 15:28:32 +0100 [thread overview]
Message-ID: <87tufg7cvj.fsf_-_@gnu.org> (raw)
In-Reply-To: <DM6PR19MB246009FC1A233E37685B9112999F9@DM6PR19MB2460.namprd19.prod.outlook.com> (Jaft's message of "Mon, 22 Nov 2021 04:26:55 +0000 (UTC)")
Hi Jaft,
Jaft <jaft.r@outlook.com> skribis:
> * gnu/packages/fonts.scm (feather): Add Feather iconfont by AT-UI
>
> The foundry, AT-UI, has a hyphen but https://guix.gnu.org/manual/en/html_node/Fonts.html
> seems to implicitly imply the foundry wouldn't have hyphens so I removed them,
> for the package name (font-atui-feather).
I think it’s fine either way.
> + (name "font-atui-feather")
> + (version "0")
> + (source (origin
> + (method url-fetch/zipbomb)
> + (uri "https://github.com/AT-UI/feather-font/archive/refs/heads/master.zip")
> + (sha256 (base32 "0lp1m1a47s56rj0q6nj8j5snkbw8jq3q7zwdzf86sbbglq170inh"))))
Note that ‘master.zip’ changes at each commit (and its content can also
change even if the HEAD commit is unchanged because it’s a generated
file.)
Could you instead change it to refer to a non-generated zip file, or use
‘git-fetch’ to obtain a checkout?
You may also need to adjust the version string.
> + (build-system font-build-system)
> + (home-page "https://at-ui.github.io/feather-font/")
> + (synopsis "Iconfont version of Feather")
> + (description "Feather is a collection of simply beautiful open source icons.
Everything is free software/data in Guix, so you can remove “open
source”. :-)
Could you send an updated patch? Preferably as a attachment to make
sure it’s not mangled on its way.
Thanks in advance!
Ludo’.
next prev parent reply other threads:[~2021-12-10 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <779747687.4148081.1637555215252.ref@mail.yahoo.com>
2021-11-22 4:26 ` [bug#52030] [PATCH] gnu: Add feather font Jaft
2021-12-10 14:28 ` Ludovic Courtès [this message]
2021-12-16 21:24 ` Jaft
2022-02-27 21:40 ` bug#52030: " Ludovic Courtès
[not found] ` <850256612.2451245.1639689873514@mail.yahoo.com>
2022-02-27 3:32 ` [bug#52030] " Jaft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tufg7cvj.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=52030@debbugs.gnu.org \
--cc=jaft.r@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.