all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Jaft <jaft.r@outlook.com>
Cc: "52030@debbugs.gnu.org" <52030-done@debbugs.gnu.org>
Subject: bug#52030: [PATCH] gnu: Add feather font
Date: Sun, 27 Feb 2022 22:40:29 +0100	[thread overview]
Message-ID: <87k0dgt2cy.fsf_-_@gnu.org> (raw)
In-Reply-To: <BN8PR19MB244907B206BEBE03E897488099779@BN8PR19MB2449.namprd19.prod.outlook.com> (Jaft's message of "Thu, 16 Dec 2021 21:24:33 +0000 (UTC)")

Hi,

Jaft <jaft.r@outlook.com> skribis:

> For some reason, I only remembered the part of the documentation that says you can submit the patch in the body of the E-mail but, double-checking my memory, it definitely also lists being able to send the patch as an attachment. I'll start doing that as others have mentioned mangling, as well.
>
> * gnu/packages/fonts.scm (feather): Add Feather iconfont by AT-UI

[...]

> +(define-public font-atui-feather
> +  (package
> +    (name "font-atui-feather")
> +    (version "0")
> +    (source (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                  (commit "c51fe7cedbcf2cbf4f1b993cef5d8def612dec1d")
> +                  (url "https://github.com/AT-UI/feather-font/")))
> +            (sha256 (base32 "0hk12bjlsh0j6kd0sz3nwax259afdi6dxws4x88yz5ssxic1ng2j"))))
> +    (build-system font-build-system)
> +    (home-page "https://at-ui.github.io/feather-font/")
> +    (synopsis "Iconfont version of Feather")
> +    (description "Feather is a collection of simply beautiful icons.
> +Each icon is designed on a 24x24 grid with an emphasis on simplicity, consistency,
> +and readability.  This package bundles those icons into a font.")
> +    (license license:expat)))

I’ve (finally!) committed a tweaked version that includes a ‘version’
field following the guidelines in
<https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html>,
also addressing another ‘guix lint’ warning about the origin.

Jaft <jaft.r@outlook.com> skribis:

> I don't know if it's generally considered poor etiquette to do this but just bumping this E-mail thread, as I believe I've done the required changes and, theoretically, this patch should be all ready to just go.

No, you were right to ping me; apologies for missing your earlier email.

In the future, it’s even more convenient for us if you can send a patch
created with ‘git send-email’.

Thank you, and sorry for the delay!

Ludo’.




  reply	other threads:[~2022-02-27 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <779747687.4148081.1637555215252.ref@mail.yahoo.com>
2021-11-22  4:26 ` [bug#52030] [PATCH] gnu: Add feather font Jaft
2021-12-10 14:28   ` Ludovic Courtès
2021-12-16 21:24     ` Jaft
2022-02-27 21:40       ` Ludovic Courtès [this message]
     [not found]     ` <850256612.2451245.1639689873514@mail.yahoo.com>
2022-02-27  3:32       ` Jaft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0dgt2cy.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=52030-done@debbugs.gnu.org \
    --cc=jaft.r@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.