all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>, 58231@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#58231] [PATCH 2/2] packages: Raise an exception for invalid 'license' values.
Date: Mon, 10 Oct 2022 12:22:18 +0200	[thread overview]
Message-ID: <87tu4crnad.fsf@gmail.com> (raw)
In-Reply-To: <20221001162058.8214-2-ludo@gnu.org>

Hi,

Well, I am a bit late. :-)


On sam., 01 oct. 2022 at 18:20, Ludovic Courtès <ludo@gnu.org> wrote:

>  ;; A package.
>  (define-record-type* <package>
>    package make-package
> @@ -574,7 +607,8 @@ (define-record-type* <package>
>              (sanitize validate-texinfo))          ; one-line description
>    (description package-description
>                 (sanitize validate-texinfo))       ; one or two paragraphs
> -  (license package-license)                       ; (list of) <license>
> +  (license package-license                        ; (list of) <license>
> +           (sanitize validate-license))
>    (home-page package-home-page)
>    (supported-systems package-supported-systems    ; list of strings
>                       (default %supported-systems))

This change is the core, IIUC.  The question is: does it make sense to
have something similar for all the fields?

For instance, the fields ’name’ and ’verson’ are expected to be ’string’
and could be similarly checked?

Although, the overhead by «Compute derivation» could too much.


Cheers,
simon




  reply	other threads:[~2022-10-10 10:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01 16:19 [bug#58231] [PATCH 0/2] Checking the 'license' field of packages Ludovic Courtès
2022-10-01 16:20 ` [bug#58231] [PATCH 1/2] licenses: Let 'license?' expand to #t in trivial cases Ludovic Courtès
2022-10-01 16:20   ` [bug#58231] [PATCH 2/2] packages: Raise an exception for invalid 'license' values Ludovic Courtès
2022-10-10 10:22     ` zimoun [this message]
2022-10-10 14:52       ` Ludovic Courtès
2022-10-15 22:12         ` Philip McGrath
2022-10-08 11:44 ` [bug#58231] [PATCH 0/2] Checking the 'license' field of packages pelzflorian (Florian Pelz)
2022-10-10  7:36   ` Ludovic Courtès
2022-10-10  7:51 ` Ludovic Courtès
2022-10-10  9:20 ` Heads-up: Run “make clean-go && make” Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu4crnad.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=58231@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.