From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0J0+MG/zQ2OaDwAAbAwnHQ (envelope-from ) for ; Mon, 10 Oct 2022 12:26:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MIdUMG/zQ2N4fwAA9RJhRA (envelope-from ) for ; Mon, 10 Oct 2022 12:26:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C3441426B for ; Mon, 10 Oct 2022 12:26:55 +0200 (CEST) Received: from localhost ([::1]:37056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohpzq-0001px-Bv for larch@yhetil.org; Mon, 10 Oct 2022 06:26:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohpz0-0001mj-Iz for guix-patches@gnu.org; Mon, 10 Oct 2022 06:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohpyz-0005Ch-UL for guix-patches@gnu.org; Mon, 10 Oct 2022 06:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohpyz-0005ws-PG for guix-patches@gnu.org; Mon, 10 Oct 2022 06:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58231] [PATCH 2/2] packages: Raise an exception for invalid 'license' values. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Oct 2022 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58231 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 58231@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 58231-submit@debbugs.gnu.org id=B58231.166539752722826 (code B ref 58231); Mon, 10 Oct 2022 10:26:01 +0000 Received: (at 58231) by debbugs.gnu.org; 10 Oct 2022 10:25:27 +0000 Received: from localhost ([127.0.0.1]:46196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohpyR-0005w5-2a for submit@debbugs.gnu.org; Mon, 10 Oct 2022 06:25:27 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:41863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohpyE-0005pt-5e for 58231@debbugs.gnu.org; Mon, 10 Oct 2022 06:25:24 -0400 Received: by mail-wr1-f44.google.com with SMTP id bu30so16300912wrb.8 for <58231@debbugs.gnu.org>; Mon, 10 Oct 2022 03:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=I8htZDCg0maJpn+7RJhrkmrhv0s0HwuYQxrDiA0Cow0=; b=HS7ZPhz22ZiGdS8EMUCaEVG5TBSs+RdZ5aUG88kjxmEYzE91VhKsdqdzdemzHP/gJj EDji5Q+B0C0guN8mJ47UKpuqt9sHXQEsaz+lKSGdKDS/ReGhemXOX5IqKoVl2t6FGHx/ tRJOp3Ox7DHPLOMYcv5NXpDRqLsx5XYocx5yHjAaeA7mEqkZhBauW3eYsGkDGonMZum+ J6byIqXcaosotR2shdo18J8ItrEiFFLoWv4cuZkxX0j/5q2poZJ6TkM6Pj4zxXaLU/TT nbSoXLCU3pZLe9fBpCO6wG6yAv8q5/L1Xm8K6b9RVih4FIAPC12wNxiZPdVX+sm8b1R5 g4Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I8htZDCg0maJpn+7RJhrkmrhv0s0HwuYQxrDiA0Cow0=; b=VWaQvvX7S39nA1EL4du7aKWEtzpVJbb+DFWWVYn3Ry3lxS7ycDFFVBcpcX/KqpKDH7 lH4R/7PJBfgzXE9m4f4tPDxjqT7XNWqBW4dC/icDFgXkCMhb/lzRqXVldwtCrI3pf1w+ A/ZxVTIf0Kqax2BNvNv+Pzi8HoASXBDNFIWWx8lbsLKGoVHUul291FrY2RunhA52tyul nHvPGtv+pzAv2owD+yhyU2e9xq7h0fTnd97XJT8Ma6dASbrPVtI+nm5MAF4/rBafRoZS fDVC0k9xjMNXdI3NVn+fWOD55Uo91l/vxGUapSTsMedT2yMXL67C6vDC5Hj0Y0acj83M KZGg== X-Gm-Message-State: ACrzQf0GAgQxJOAQb7ers9iHBBDxS6eWhn4XBew9VKKtyHywhqUnPw1i Mq+GZcp9NXCBZnqlnYQTQEw= X-Google-Smtp-Source: AMsMyM7hGQYeR2Au0qGx4myyH16NyJ0+sx/YGVvCPLI5tYErTJmsawl5laWXtXUZW41BWpTnFTlHpg== X-Received: by 2002:a5d:6181:0:b0:22e:3db0:67a2 with SMTP id j1-20020a5d6181000000b0022e3db067a2mr11362973wru.257.1665397507163; Mon, 10 Oct 2022 03:25:07 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id w5-20020a5d6805000000b002285f73f11dsm10813005wru.81.2022.10.10.03.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 03:25:06 -0700 (PDT) From: zimoun In-Reply-To: <20221001162058.8214-2-ludo@gnu.org> References: <20221001162058.8214-1-ludo@gnu.org> <20221001162058.8214-2-ludo@gnu.org> Date: Mon, 10 Oct 2022 12:22:18 +0200 Message-ID: <87tu4crnad.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665397615; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=I8htZDCg0maJpn+7RJhrkmrhv0s0HwuYQxrDiA0Cow0=; b=jcm8gmdVfhkGnuK2+aCMzg7LBrH24LXb93XrrK1OyOMBKG7RATHElRky6FRiW1/WjZ9AEt keXw2UoaAV556WM3hfMxYSidek+ARwdOXukrEPvnjN6aDCIafnOkCVOCfoeVscr8iM6dPa E0g+VbQ0jTGJhj06q3DljM/P7Fcl5ny+sE0h5P3cSE9XUPIyR2OfzkotHWvRaejAUfLh8w yI49Zukh8gAxHpQjcDm95aNsmoN1Mmeneq7n4srVU2P1Eov+uqSBXzME836xXvewXdnuOb r9P9kzsQyUqP6wSwYn+GM8HswxZfqv1u2MQ0bSYwAIhv0kVr1su37+L/g19MIQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665397615; a=rsa-sha256; cv=none; b=dLavk4gkYv7BZHc6E8pqDUgfRhKbCRWaWEY0og1I1opF09czn8eMdpPoZ8Qh+cstkMfiux 1ZZj7M423cVIRFMp+FhXX4YL7bEEgfpwJiVbv2EgGkB+sqZ4SKHdVQWvOF2pA5GbQz52Xn 9HjKczF+r7J35+Vju9kVgJXKqAElA7ewUxfWMwvNvfcf13GeFHUyFcXjmkJ0LojDoqmtK+ fLxj7vkNs6goKBCaRwQZeNjjMkdsdE6R5hnJ4BHiXPeaarsWx1xyTht58vxykq56km/k1c nAfjpCE8c7WMyyqo6Jf9PiC9GcxDupWR48gkY87LKmRLiuh2ECdv2ErUmxPiUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HS7ZPhz2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HS7ZPhz2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9C3441426B X-Spam-Score: 6.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: tR5zmyqhDn8c Hi, Well, I am a bit late. :-) On sam., 01 oct. 2022 at 18:20, Ludovic Court=C3=A8s wrote: > ;; A package. > (define-record-type* > package make-package > @@ -574,7 +607,8 @@ (define-record-type* > (sanitize validate-texinfo)) ; one-line description > (description package-description > (sanitize validate-texinfo)) ; one or two paragraphs > - (license package-license) ; (list of) > + (license package-license ; (list of) > + (sanitize validate-license)) > (home-page package-home-page) > (supported-systems package-supported-systems ; list of strings > (default %supported-systems)) This change is the core, IIUC. The question is: does it make sense to have something similar for all the fields? For instance, the fields =E2=80=99name=E2=80=99 and =E2=80=99verson=E2=80= =99 are expected to be =E2=80=99string=E2=80=99 and could be similarly checked? Although, the overhead by =C2=ABCompute derivation=C2=BB could too much. Cheers, simon