all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] import: pypi: Don't add setuptools to propagated-inputs.
@ 2017-01-21  5:31 Carlo Zancanaro
  2017-01-26 12:46 ` Hartmut Goebel
  0 siblings, 1 reply; 2+ messages in thread
From: Carlo Zancanaro @ 2017-01-21  5:31 UTC (permalink / raw)
  To: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 191 bytes --]

The pypi importer currently adds python-setuptools to the propagated
inputs. According to the manual we don't need to do this any more, so
here's a patch that updates the importer to match.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-import-pypi-Don-t-add-setuptools-to-propagated-input.patch --]
[-- Type: text/x-patch, Size: 1244 bytes --]

From d819fce415614d269fbb28f035963e6e0d6efbee Mon Sep 17 00:00:00 2001
From: Carlo Zancanaro <carlo@zancanaro.id.au>
Date: Sat, 21 Jan 2017 16:15:21 +1100
Subject: [PATCH] import: pypi: Don't add setuptools to propagated-inputs.

* guix/import/pypi.scm (compute-inputs): Don't add setuptools to the imported
  package's propagated-inputs.
---
 guix/import/pypi.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index 7cce0fc59..ed0d4297a 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -227,10 +227,8 @@ name/variable pairs describing the required inputs of this package."
   (sort
     (map (lambda (input)
            (list input (list 'unquote (string->symbol input))))
-         (append '("python-setuptools")
-                 ;; Argparse has been part of Python since 2.7.
-                 (remove (cut string=? "python-argparse" <>)
-                         (guess-requirements source-url wheel-url tarball))))
+         (remove (cut string=? "python-argparse" <>)
+                 (guess-requirements source-url wheel-url tarball)))
     (lambda args
       (match args
         (((a _ ...) (b _ ...))
-- 
2.11.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] import: pypi: Don't add setuptools to propagated-inputs.
  2017-01-21  5:31 [PATCH] import: pypi: Don't add setuptools to propagated-inputs Carlo Zancanaro
@ 2017-01-26 12:46 ` Hartmut Goebel
  0 siblings, 0 replies; 2+ messages in thread
From: Hartmut Goebel @ 2017-01-26 12:46 UTC (permalink / raw)
  To: guix-devel@gnu.org >> guix-devel

Am 21.01.2017 um 06:31 schrieb Carlo Zancanaro:
> The pypi importer currently adds python-setuptools to the propagated
> inputs. According to the manual we don't need to do this any more, so
> here's a patch that updates the importer to match.
>

Well spotted :-) Pushed as 2f977d92d3ae517788d3dee98f63680ca149aa1a

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-26 12:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-21  5:31 [PATCH] import: pypi: Don't add setuptools to propagated-inputs Carlo Zancanaro
2017-01-26 12:46 ` Hartmut Goebel

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.