[bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

[bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

[Alex Kost]

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]

Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
to 'emacs-paredit')?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-git-modes-Rename-to-emacs-git-modes.patch --]
[-- Type: text/x-patch, Size: 1196 bytes --]

From 6b36950703b1fa589ac0ee9e2343c7970a7859f6 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Tue, 5 Dec 2017 23:27:23 +0300
Subject: [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

* gnu/packages/emacs.scm (git-modes)[name]: Change to "emacs-git-modes".
(git-modes/old-name): New variable.
---
 gnu/packages/emacs.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e5e6cf097..0ca8add53 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -377,7 +377,7 @@ when typing parentheses directly or commenting out code line by line.")
 
 (define-public git-modes
   (package
-    (name "git-modes")
+    (name "emacs-git-modes")
     (version "1.2.6")
     (source (origin
               (method url-fetch)
@@ -396,6 +396,9 @@ when typing parentheses directly or commenting out code line by line.")
 configuration files, such as .gitattributes, .gitignore, and .git/config.")
     (license license:gpl3+)))
 
+(define-public git-modes/old-name
+  (deprecated-package "git-modes" git-modes))
+
 (define-public emacs-with-editor
   (package
     (name "emacs-with-editor")
-- 
2.14.2

[bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

[Ludovic Courtès]

Hi,

Alex Kost <alezost@gmail.com> skribis:

> Then I'm lost here: it is absolutely not clear for me where the border
> between libraries and end-user applications lies in the Emacs world.
> Such things as "emacs-dash" or "emacs-s" are definitely libraries but
> most of the other Emacs packages are intended for users but we still
> prefix them ("emacs-auctex", "emacs-pdf-tools", etc.)

“emacs-git-modes” looks appropriate to me here and consistent with the
choices we’ve made so far.

Thanks Alex,
Ludo’.

bug#29582: [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

[Alex Kost]

Ludovic Courtès (2017-12-08 10:44 +0100) wrote:

> Hi,
>
> Alex Kost <alezost@gmail.com> skribis:
>
>> Then I'm lost here: it is absolutely not clear for me where the border
>> between libraries and end-user applications lies in the Emacs world.
>> Such things as "emacs-dash" or "emacs-s" are definitely libraries but
>> most of the other Emacs packages are intended for users but we still
>> prefix them ("emacs-auctex", "emacs-pdf-tools", etc.)
>
> “emacs-git-modes” looks appropriate to me here and consistent with the
> choices we’ve made so far.

Committed as 6d21272b2, thanks all for the comments!

-- 
Alex