From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Evan Straw <evan.straw99@gmail.com>
Cc: 40284@debbugs.gnu.org
Subject: [bug#40284] [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork.
Date: Mon, 30 Mar 2020 01:59:07 +0200 [thread overview]
Message-ID: <87sghqaf1w.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87k13220st.fsf@gmail.com> (Evan Straw's message of "Sun, 29 Mar 2020 16:34:10 -0700")
Hello,
Evan Straw <evan.straw99@gmail.com> writes:
> Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork.
>
> * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained
> fork.
Thank you.
> - (let ((commit "3e2bad4569ad26e929e6db2cbcff0d6d36812698")) ;no release yet
> + (let ((commit "23ae47c9f28f559e70b790b471f20310e163a39b")) ;no release yet
> (package
> (name "emacs-arduino-mode")
> (version (git-version "0" "0" commit))
We want to increment version, too, so the above should be:
(git-version "0" "1" commit)
For clarity, you may want to bind `revision' to "1" right after `commit'
and use that in the `git-version' call.
> + (add-after 'unpack 'fix-obsolete
> + (lambda _
> + (substitute* "ede-arduino.el"
> + (("defmethod") "cl-defmethod")
> + (("defgeneric") "cl-defgeneric")))))))
The phase must end with a #f
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-03-30 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 23:34 [bug#40284] [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork Evan Straw
2020-03-29 23:59 ` Nicolas Goaziou [this message]
2020-03-30 0:42 ` Tobias Geerinckx-Rice via Guix-patches via
2020-03-30 10:12 ` Nicolas Goaziou
2020-03-30 0:56 ` [bug#40284] [PATCH v2] " Evan Straw
2020-03-30 12:01 ` bug#40284: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sghqaf1w.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40284@debbugs.gnu.org \
--cc=evan.straw99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.