From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:38572)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIhqV-00067J-K8
 for guix-patches@gnu.org; Sun, 29 Mar 2020 20:00:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIhqU-0000MV-L1
 for guix-patches@gnu.org; Sun, 29 Mar 2020 20:00:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48528)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jIhqU-0000LD-HQ
 for guix-patches@gnu.org; Sun, 29 Mar 2020 20:00:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIhqU-0000GW-Ee
 for guix-patches@gnu.org; Sun, 29 Mar 2020 20:00:02 -0400
Subject: [bug#40284] [PATCH] gnu: emacs-arduino-mode: Change to a maintained
 fork.
Resent-Message-ID: <handler.40284.B40284.1585526358928@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <87k13220st.fsf@gmail.com>
Date: Mon, 30 Mar 2020 01:59:07 +0200
In-Reply-To: <87k13220st.fsf@gmail.com> (Evan Straw's message of "Sun, 29 Mar
 2020 16:34:10 -0700")
Message-ID: <87sghqaf1w.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Evan Straw <evan.straw99@gmail.com>
Cc: 40284@debbugs.gnu.org

Hello,

Evan Straw <evan.straw99@gmail.com> writes:

> Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork.
>
> * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained
>   fork.

Thank you.

> -  (let ((commit "3e2bad4569ad26e929e6db2cbcff0d6d36812698")) ;no release yet
> +  (let ((commit "23ae47c9f28f559e70b790b471f20310e163a39b")) ;no release yet
>      (package
>        (name "emacs-arduino-mode")
>        (version (git-version "0" "0" commit))

We want to increment version, too, so the above should be:

  (git-version "0" "1" commit)

For clarity, you may want to bind `revision' to "1" right after `commit'
and use that in the `git-version' call.

> +           (add-after 'unpack 'fix-obsolete
> +             (lambda _
> +               (substitute* "ede-arduino.el"
> +                 (("defmethod") "cl-defmethod")
> +                 (("defgeneric") "cl-defgeneric")))))))

The phase must end with a #f

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou