From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Soo <jsoo1@asu.edu>
Cc: 40300@debbugs.gnu.org
Subject: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Date: Mon, 30 Mar 2020 19:52:29 +0200 [thread overview]
Message-ID: <87sghp6882.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <877dz1wxom.fsf@asu.edu> (John Soo's message of "Mon, 30 Mar 2020 10:38:01 -0700")
Hello,
John Soo <jsoo1@asu.edu> writes:
> +(define-public emacs-haskell-snippets
> + (package
> + (name "emacs-haskell-snippets")
> + (version "0.1.0")
Would it make sense to package HEAD instead. I'm looking in particular
at upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5.
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/haskell/haskell-snippets")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6"))))
Usual nitpick: please put string on the same line as `base32'.
> + (inputs
> + `(("emacs-yasnippet" ,emacs-yasnippet)))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'install-snippets
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (snippets
> + (string-append
> + out "/share/emacs/site-lisp/snippets/haskell-mode")))
> + (mkdir-p snippets)
> + (copy-recursively "snippets/haskell-mode" snippets)
> + #t))))))
> + (build-system emacs-build-system)
Nitpick: could you move parts in this order: build-system ->
arguments -> inputs.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-03-30 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 1:07 [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets John Soo
2020-03-30 17:17 ` Nicolas Goaziou
2020-03-30 17:38 ` John Soo
2020-03-30 17:52 ` Nicolas Goaziou [this message]
2020-03-30 19:03 ` John Soo
2020-03-30 20:39 ` bug#40300: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sghp6882.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40300@debbugs.gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.