From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39047)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIyat-0002QP-MI
 for guix-patches@gnu.org; Mon, 30 Mar 2020 13:53:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIyas-00058B-AU
 for guix-patches@gnu.org; Mon, 30 Mar 2020 13:53:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:51698)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jIyas-00057P-7H
 for guix-patches@gnu.org; Mon, 30 Mar 2020 13:53:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIyar-00077c-U3
 for guix-patches@gnu.org; Mon, 30 Mar 2020 13:53:01 -0400
Subject: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Resent-Message-ID: <handler.40300.B40300.158559075927334@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <87k1342cl1.fsf@asu.edu> <871rp97ofd.fsf@nicolasgoaziou.fr>
 <877dz1wxom.fsf@asu.edu>
Date: Mon, 30 Mar 2020 19:52:29 +0200
In-Reply-To: <877dz1wxom.fsf@asu.edu> (John Soo's message of "Mon, 30 Mar 2020
 10:38:01 -0700")
Message-ID: <87sghp6882.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 40300@debbugs.gnu.org

Hello,

John Soo <jsoo1@asu.edu> writes:

> +(define-public emacs-haskell-snippets
> +  (package
> +    (name "emacs-haskell-snippets")
> +    (version "0.1.0")

Would it make sense to package HEAD instead. I'm looking in particular
at upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/haskell/haskell-snippets")
> +         (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6"))))

Usual nitpick: please put string on the same line as `base32'.

> +    (inputs
> +     `(("emacs-yasnippet" ,emacs-yasnippet)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'install-snippets
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (snippets
> +                     (string-append
> +                      out "/share/emacs/site-lisp/snippets/haskell-mode")))
> +               (mkdir-p snippets)
> +               (copy-recursively "snippets/haskell-mode" snippets)
> +               #t))))))
> +    (build-system emacs-build-system)

Nitpick: could you move parts in this order: build-system ->
arguments -> inputs.

Regards,

-- 
Nicolas Goaziou