all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jan Nieuwenhuizen <janneke@gnu.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 40901@debbugs.gnu.org
Subject: [bug#40901] gnu: ktsuss: Fix paths.
Date: Tue, 28 Apr 2020 19:13:07 +0200	[thread overview]
Message-ID: <87sggncz4s.fsf@gnu.org> (raw)
In-Reply-To: <20200427093702.16f9d953.raghavgururajan@disroot.org>

Raghav Gururajan writes:

Hello Raghav,

>> Can you please remember to test a program before submitting it?  And I
>> mean not only check if "it runs", but also if it is actually useful?
>
> Sorry. I have attached a patch with this email to make ktsuss work
> correctly.

Hmm, I experienced no problem when I tested it.  What did you observe
(see my question below).

> From a1d5a14bb634fe52201fdde9ffbd3e385b89d234 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Tue, 28 Apr 2020 03:34:05 -0400
> Subject: [PATCH 2/2] gnu: ktsuss: Disable sudo.
>
> * gnu/packages/admin.scm (ktsuss): Disable sudo.
>
> Disabled sudo-backend as there is an unknown bug in upstream.
> Ktsuss now fall-back to using su-backend, which works correctly.

Having a like this is great.  Two remarks

  * please move it above the "* gnu/packages/admin" line
  * it would be great if you can add link to the ktsuss bug tracer about
    this "unknown" bug

Without any indication about what the bug is or how it can be
reproduced, it becomes hard to remove this workaround.

Other than that: LGTM.

Greetings,
janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

  reply	other threads:[~2020-04-28 17:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 13:37 [bug#40901] gnu: ktsuss: Fix paths Raghav Gururajan
2020-04-27 16:21 ` Jan Nieuwenhuizen
2020-04-28  7:43   ` Raghav Gururajan
2020-04-28 17:13     ` Jan Nieuwenhuizen [this message]
2020-04-30  8:39       ` Raghav Gururajan
2020-04-30 13:54         ` Raghav Gururajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sggncz4s.fsf@gnu.org \
    --to=janneke@gnu.org \
    --cc=40901@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.