From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39922) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTTo3-0007vj-7g for guix-patches@gnu.org; Tue, 28 Apr 2020 13:14:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTTo2-0001kp-Mn for guix-patches@gnu.org; Tue, 28 Apr 2020 13:14:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTTo2-0001kg-9h for guix-patches@gnu.org; Tue, 28 Apr 2020 13:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTTo2-0006lL-4o for guix-patches@gnu.org; Tue, 28 Apr 2020 13:14:02 -0400 Subject: [bug#40901] gnu: ktsuss: Fix paths. In-Reply-To: <20200427093702.16f9d953.raghavgururajan@disroot.org> Resent-Message-ID: From: Jan Nieuwenhuizen References: <20200427093702.16f9d953.raghavgururajan@disroot.org> <87k120527o.fsf@gnu.org> <20200428034314.37f199f3.raghavgururajan@disroot.org> Date: Tue, 28 Apr 2020 19:13:07 +0200 Message-ID: <87sggncz4s.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 40901@debbugs.gnu.org Raghav Gururajan writes: Hello Raghav, >> Can you please remember to test a program before submitting it? And I >> mean not only check if "it runs", but also if it is actually useful? > > Sorry. I have attached a patch with this email to make ktsuss work > correctly. Hmm, I experienced no problem when I tested it. What did you observe (see my question below). > From a1d5a14bb634fe52201fdde9ffbd3e385b89d234 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Tue, 28 Apr 2020 03:34:05 -0400 > Subject: [PATCH 2/2] gnu: ktsuss: Disable sudo. > > * gnu/packages/admin.scm (ktsuss): Disable sudo. > > Disabled sudo-backend as there is an unknown bug in upstream. > Ktsuss now fall-back to using su-backend, which works correctly. Having a like this is great. Two remarks * please move it above the "* gnu/packages/admin" line * it would be great if you can add link to the ktsuss bug tracer about this "unknown" bug Without any indication about what the bug is or how it can be reproduced, it becomes hard to remove this workaround. Other than that: LGTM. Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com